From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 58E0A1FF13A for ; Wed, 08 Jul 2026 15:37:07 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id F38B92144C; Wed, 08 Jul 2026 15:37:06 +0200 (CEST) From: Dominik Csapak To: pdm-devel@lists.proxmox.com Subject: [PATCH datacenter-manager 2/2] server: api: pve firewall: remove 'remote' parameter from overall status Date: Wed, 8 Jul 2026 15:36:24 +0200 Message-ID: <20260708133630.1807997-3-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260708133630.1807997-1-d.csapak@proxmox.com> References: <20260708133630.1807997-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.059 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: IO5ZEEOXJX7JH72SGNZV2XN4THSDHZKH X-Message-ID-Hash: IO5ZEEOXJX7JH72SGNZV2XN4THSDHZKH X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: this is the api call for the overall status, not a specific remote, so there isn't a 'remote' parameter to limit us to. Simply require audit on '/resource' to indicate we need resource permissions. This fixes a 403 error on the firewall panel for non root@pam users. Signed-off-by: Dominik Csapak --- server/src/api/pve/firewall.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/src/api/pve/firewall.rs b/server/src/api/pve/firewall.rs index 5a6a209e..6c18ba10 100644 --- a/server/src/api/pve/firewall.rs +++ b/server/src/api/pve/firewall.rs @@ -242,7 +242,7 @@ async fn fetch_node_firewall_status( items: { type: RemoteFirewallStatus }, }, access: { - permission: &Permission::Privilege(&["resource", "{remote}"], PRIV_RESOURCE_AUDIT, false), + permission: &Permission::Privilege(&["resource"], PRIV_RESOURCE_AUDIT, false), }, )] /// Get firewall status of all PVE remotes. -- 2.47.3