all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Elias Huhsovitz <e.huhsovitz@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Elias Huhsovitz <e.huhsovitz@proxmox.com>
Subject: [PATCH widget-toolkit 1/2] fix #7426: ui: network: use correct name tooltips for interface types
Date: Mon,  6 Jul 2026 13:14:54 +0200	[thread overview]
Message-ID: <20260706111455.106630-2-e.huhsovitz@proxmox.com> (raw)
In-Reply-To: <20260706111455.106630-1-e.huhsovitz@proxmox.com>

The tooltip for the interface name field incorrectly showed VLAN
examples (e.g., vmbr0.100) when creating a Provide accurate tooltips for
Bridges, Bonds and VLANs.

Signed-off-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>
---
 src/node/NetworkEdit.js | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/node/NetworkEdit.js b/src/node/NetworkEdit.js
index c945139..b08d5ff 100644
--- a/src/node/NetworkEdit.js
+++ b/src/node/NetworkEdit.js
@@ -22,23 +22,23 @@ Ext.define('Proxmox.node.NetworkEdit', {
         me.isCreate = !me.iface;
 
         let iface_vtype;
+        let iface_tooltip;
 
-        if (me.iftype === 'bridge') {
+        if (me.iftype === 'bridge' || me.iftype === 'OVSBridge') {
             iface_vtype = 'BridgeName';
-        } else if (me.iftype === 'bond') {
+            iface_tooltip = gettext('Commonly: vmbr[N] (e.g., vmbr0, vmbr1). Must start with a character, max 10 alphanumeric characters.');
+        } else if (me.iftype === 'bond' || me.iftype === 'OVSBond') {
             iface_vtype = 'BondName';
+            iface_tooltip = gettext('Format: bond[N] (e.g., bond0, bond1)');
         } else if (me.iftype === 'eth' && !me.isCreate) {
             iface_vtype = 'InterfaceName';
+            iface_tooltip = gettext('Format: eth[N] (e.g., eth0, enp0s3, )');
         } else if (me.iftype === 'vlan') {
             iface_vtype = 'VlanName';
-        } else if (me.iftype === 'OVSBridge') {
-            iface_vtype = 'BridgeName';
-        } else if (me.iftype === 'OVSBond') {
-            iface_vtype = 'BondName';
-        } else if (me.iftype === 'OVSIntPort') {
-            iface_vtype = 'InterfaceName';
-        } else if (me.iftype === 'OVSPort') {
+            iface_tooltip = gettext('Format: [interface].[vlan-id] (e.g., eno1.50, bond1.30)');
+        } else if (me.iftype === 'OVSIntPort' || me.iftype === 'OVSPort') {
             iface_vtype = 'InterfaceName';
+            iface_tooltip = gettext('Alphanumeric string starting with a character.');
         } else {
             console.log(me.iftype);
             throw 'unknown network device type specified';
@@ -332,7 +332,7 @@ Ext.define('Proxmox.node.NetworkEdit', {
                 maxLength: iface_vtype === 'BridgeName' ? 10 : 15,
                 autoEl: {
                     tag: 'div',
-                    'data-qtip': gettext('For example, vmbr0.100, vmbr0, vlan0.100, vlan0'),
+                    'data-qtip': iface_tooltip,
                 },
                 listeners: {
                     change: function (f, value) {
-- 
2.47.3





  reply	other threads:[~2026-07-06 11:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06 11:14 [PATCH widget-toolkit/yew-comp 0/2] Subject: fix #7426: use correct name tooltips for network interface types Elias Huhsovitz
2026-07-06 11:14 ` Elias Huhsovitz [this message]
2026-07-06 11:14 ` [PATCH yew-comp 2/2] fix #7426: ui: network: use correct name tooltips for " Elias Huhsovitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260706111455.106630-2-e.huhsovitz@proxmox.com \
    --to=e.huhsovitz@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal