From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 08C191FF153 for ; Mon, 06 Jul 2026 10:03:27 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id AE14D21445; Mon, 06 Jul 2026 10:03:26 +0200 (CEST) From: Maximiliano Sandoval To: pbs-devel@lists.proxmox.com Subject: [PATCH backup v4 3/4] client: rename password to blob Date: Mon, 6 Jul 2026 10:02:43 +0200 Message-ID: <20260706080246.108256-4-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260706080246.108256-1-m.sandoval@proxmox.com> References: <20260706080246.108256-1-m.sandoval@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1783324991887 X-SPAM-LEVEL: Spam detection results: 0 DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 5ITZSQBJ35AVVYNTGQUHGRDWYCIVZIDE X-Message-ID-Hash: 5ITZSQBJ35AVVYNTGQUHGRDWYCIVZIDE X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This is a Vec and not yet the password in its unicode form. Signed-off-by: Maximiliano Sandoval --- pbs-client/src/tools/mod.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pbs-client/src/tools/mod.rs b/pbs-client/src/tools/mod.rs index ca64b239e..d99215c44 100644 --- a/pbs-client/src/tools/mod.rs +++ b/pbs-client/src/tools/mod.rs @@ -169,8 +169,8 @@ fn get_secret_from_env(base_name: &str) -> Result, Error> { fn get_secret_impl(env_variable: &str, credential_name: &str) -> Result, Error> { if let Some(password) = get_secret_from_env(env_variable)? { Ok(Some(password)) - } else if let Some(password) = get_credential(credential_name)? { - String::from_utf8(password) + } else if let Some(blob) = get_credential(credential_name)? { + String::from_utf8(blob) .map(Option::Some) .map_err(|_err| format_err!("credential {credential_name} is not utf8 encoded")) } else { -- 2.47.3