From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id CD5C31FF150 for ; Mon, 06 Jul 2026 10:03:57 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 0530421465; Mon, 06 Jul 2026 10:03:57 +0200 (CEST) From: Maximiliano Sandoval To: pbs-devel@lists.proxmox.com Subject: [PATCH backup v4 0/4] fix #7054: client: remove trailing newlines from credentials Date: Mon, 6 Jul 2026 10:02:40 +0200 Message-ID: <20260706080246.108256-1-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1783324991706 X-SPAM-LEVEL: Spam detection results: 0 DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6DZ3TEO5FLOPKBB6JEIKVC3YWGQTA7DM X-Message-ID-Hash: 6DZ3TEO5FLOPKBB6JEIKVC3YWGQTA7DM X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: See the first commit for more details. This was tested with proxmox-backup-client making a login/backup using different credentials with and without newlines. The commands were similar to the systemd-run commands at the Backup Client Usage docs. I did not find a way to create the keyfile with newlines in its password using proxmox-backup-client since it reads from the tty stdin, but surely it could be created manually. Perhaps it is safe-ish to also remove trailing control characters from the encryption password but this seems a safer approach for now. Differences from v3: - Move trim_end calls to get_password, get_repository, get_fingerprint - Remove "in general" from the documentation - Rename get_secret_impl to get_secret_string Diferences from v2: - Reworded commit messages following feedback form v1. Diferences from v1: - Always do an extra allocation to keep the code clean - Rename password to blob - Only strip newlines on passwords Maximiliano Sandoval (4): fix #7054: client: remove trailing newlines from credentials docs: client: document further password constrains client: rename password to blob client: Rename get_secret_impl method docs/backup-client.rst | 7 ++++--- pbs-client/src/tools/mod.rs | 17 ++++++++++------- 2 files changed, 14 insertions(+), 10 deletions(-) -- 2.47.3