From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox 2/4] s3-client: add 429 HTTP status code as retryable
Date: Tue, 30 Jun 2026 16:28:26 +0200 [thread overview]
Message-ID: <20260630142828.660821-3-c.ebner@proxmox.com> (raw)
In-Reply-To: <20260630142828.660821-1-c.ebner@proxmox.com>
When enforcing request rate limits, providers might return HTTP
status code 429 signaling too may requests. Since on retry there
will be a backoff time and the request rate limiter will be checked
again, retry requests which returned this status codes as well.
Fixes: https://forum.proxmox.com/threads/184371/
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
proxmox-s3-client/src/client.rs | 1 +
1 file changed, 1 insertion(+)
diff --git a/proxmox-s3-client/src/client.rs b/proxmox-s3-client/src/client.rs
index 5c8fe43f..fea98f27 100644
--- a/proxmox-s3-client/src/client.rs
+++ b/proxmox-s3-client/src/client.rs
@@ -515,6 +515,7 @@ impl S3Client {
StatusCode::INTERNAL_SERVER_ERROR
| StatusCode::SERVICE_UNAVAILABLE
| StatusCode::GATEWAY_TIMEOUT
+ | StatusCode::TOO_MANY_REQUESTS
),
Err(_) => true,
};
--
2.47.3
next prev parent reply other threads:[~2026-06-30 14:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 14:28 [RFC proxmox{,-backup} 0/4] fix #6841: implement request rate limits for all methods Christian Ebner
2026-06-30 14:28 ` [PATCH proxmox 1/4] fix #6841: allow to set active/passive request rate limits Christian Ebner
2026-06-30 14:28 ` Christian Ebner [this message]
2026-06-30 14:28 ` [PATCH proxmox-backup 3/4] s3: config: update or delete active/passive request limit options Christian Ebner
2026-06-30 14:28 ` [PATCH proxmox-backup 4/4] ui: expose request rate limit config options for S3 endpoints Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260630142828.660821-3-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.