all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Daniel Kral <d.kral@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [RFC PATCH guest-common] tunnel: treat reader_stderr as optional parameter in read_tunnel
Date: Tue, 30 Jun 2026 10:43:32 +0200	[thread overview]
Message-ID: <20260630084332.32566-1-d.kral@proxmox.com> (raw)

The reader_stderr parameter was introduced for a specific use case for
the users of fork_ssh_tunnel(). The other callers, such as
fork_websocket_tunnel(), do not provide the parameter and the Perl
interpreter will warn about this:

    Use of uninitialized value $reader_stderr in <HANDLE> at /usr/share/perl5/PVE/Tunnel.pm line 77.
    readline() on unopened filehandle at /usr/share/perl5/PVE/Tunnel.pm line 77.

Therefore, treat reader_stderr as an optional parameter by not reading
from the handle if it is not provided.

Fixes: 8c8aa63 ("tunnel: redirect stderr to log function")
Signed-off-by: Daniel Kral <d.kral@proxmox.com>
---
 src/PVE/Tunnel.pm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/PVE/Tunnel.pm b/src/PVE/Tunnel.pm
index 148a8e2..68547a5 100644
--- a/src/PVE/Tunnel.pm
+++ b/src/PVE/Tunnel.pm
@@ -74,8 +74,10 @@ sub read_tunnel {
     };
     my $err = $@;
 
-    while (my $line = <$reader_stderr>) { # $reader_stderr is set up as non-blocking
-        $tunnel->{log}->('warn', $line);
+    if (defined($reader_stderr)) {
+        while (my $line = <$reader_stderr>) { # $reader_stderr is set up as non-blocking
+            $tunnel->{log}->('warn', $line);
+        }
     }
 
     die "reading from tunnel failed: $err\n" if $err;
-- 
2.47.3





             reply	other threads:[~2026-06-30  8:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-30  8:43 Daniel Kral [this message]
2026-07-01 12:31 ` [RFC PATCH guest-common] tunnel: treat reader_stderr as optional parameter in read_tunnel Stoiko Ivanov
2026-07-03 13:35 ` applied: " Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260630084332.32566-1-d.kral@proxmox.com \
    --to=d.kral@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal