[PATCH pve-storage 5/9] luncmd: lio: modernize & clean up `list_view()` and `list_lun()` subs

["Max R. Carrara" <m.carrara@proxmox.com>]

Make the `list_view()` and `list_lun()` subs "proper" private
subroutines instead of lexically-scoped sub references.

Also improve the code style along the way.

Signed-off-by: Max R. Carrara <m.carrara@proxmox.com>
---
 src/PVE/Storage/LunCmd/LIO.pm | 34 +++++++++++++++++-----------------
 1 file changed, 17 insertions(+), 17 deletions(-)

diff --git a/src/PVE/Storage/LunCmd/LIO.pm b/src/PVE/Storage/LunCmd/LIO.pm
index abe0454b..483e2459 100644
--- a/src/PVE/Storage/LunCmd/LIO.pm
+++ b/src/PVE/Storage/LunCmd/LIO.pm
@@ -244,49 +244,49 @@ my sub extract_volname {
 }
 
 # retrieves the LUN index for a particular object
-my $list_view = sub {
+my sub list_view {
     my ($scfg, $config, $timeout, $method, @params) = @_;
-    my $lun = undef;
 
-    my $object = $params[0];
+    my $object = shift @params;
     my $volname = extract_volname($scfg, $config, $object);
+    return if !defined($volname); # nothing to search for..
+
     my $id = "$scfg->{portal}.$scfg->{target}";
     my $target = $config->{$id};
 
-    return undef if !defined($volname); # nothing to search for..
-
-    foreach my $lun (@{ $target->{luns} }) {
+    for my $lun ($target->{luns}->@*) {
         if ($lun->{storage_object} eq "$BACKSTORE/$volname") {
             return $lun->{index};
         }
     }
 
-    return $lun;
-};
+    return;
+}
 
-# determines, if the given object exists on the portal
-my $list_lun = sub {
+# determines if the given object exists on the portal
+my sub list_lun {
     my ($scfg, $config, $timeout, $method, @params) = @_;
 
-    my $object = $params[0];
+    my $object = shift @params;
     my $volname = extract_volname($scfg, $config, $object);
+
     my $id = "$scfg->{portal}.$scfg->{target}";
     my $target = $config->{$id};
 
-    foreach my $lun (@{ $target->{luns} }) {
+    for my $lun ($target->{luns}->@*) {
         if ($lun->{storage_object} eq "$BACKSTORE/$volname") {
             return $object;
         }
     }
 
-    return undef;
-};
+    return;
+}
 
 # adds a new LUN to the target
 my $create_lun = sub {
     my ($scfg, $config, $timeout, $method, @params) = @_;
 
-    if ($list_lun->($scfg, $config, $timeout, $method, @params)) {
+    if (list_lun($scfg, $config, $timeout, $method, @params)) {
         die "$params[0]: LUN already exists!";
     }
 
@@ -392,8 +392,8 @@ my %lun_cmd_map = (
     import_lu => $import_lun,
     modify_lu => $modify_lun,
     add_view => $add_view,
-    list_view => $list_view,
-    list_lu => $list_lun,
+    list_view => sub { list_view(@_) },
+    list_lu => sub { list_lun(@_) },
 );
 
 sub run_lun_command {
-- 
2.47.3