From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 89EAB1FF13C for ; Thu, 25 Jun 2026 18:42:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 97DE6AC9; Thu, 25 Jun 2026 18:41:48 +0200 (CEST) From: "Max R. Carrara" To: pve-devel@lists.proxmox.com Subject: [PATCH pve-storage 2/9] luncmd: lio: fix LUN ops failing when passing nonstandard LUN path Date: Thu, 25 Jun 2026 18:40:54 +0200 Message-ID: <20260625164110.706694-3-m.carrara@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260625164110.706694-1-m.carrara@proxmox.com> References: <20260625164110.706694-1-m.carrara@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1782405670092 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.070 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ZMKPYIUEF3672YW4WWA6GQPMESWEWBLY X-Message-ID-Hash: ZMKPYIUEF3672YW4WWA6GQPMESWEWBLY X-MailFrom: m.carrara@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: For ZFS-over-iSCSI, all volumes and LUNs are usually created in the format of 'vm-100-disk-0', 'vm-420-disk-2', etc. However, it is possible to create a volume with a nonstandard volume name, for example through `pvesh`: pvesh create /nodes/localhost/storage/zfs-iscsi-lio/content \ --filename vm-110-disk-2-foo-bar-baz.raw \ --size 4G \ --vmid 110 Note that the main culprit here is actually the '.raw' suffix, because '\w' doesn't match on periods, apparently. Rather than restricting the API to match our preferred format (and potentially break things), carefully make the regex that matches on the LUN path less restrictive by also allowing to match on periods. Signed-off-by: Max R. Carrara --- src/PVE/Storage/LunCmd/LIO.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Storage/LunCmd/LIO.pm b/src/PVE/Storage/LunCmd/LIO.pm index 8e03652c..9dd25ad2 100644 --- a/src/PVE/Storage/LunCmd/LIO.pm +++ b/src/PVE/Storage/LunCmd/LIO.pm @@ -200,7 +200,7 @@ my $extract_volname = sub { my $volname = undef; my $base = get_base($scfg); - if ($lunpath =~ /^$base\/$scfg->{pool}\/([\w\-]+)$/) { + if ($lunpath =~ /^$base\/$scfg->{pool}\/([\w\-\.]+)$/) { $volname = $1; my $prefix = $get_backstore_prefix->($scfg); my $target = $get_target_settings->($scfg); -- 2.47.3