From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id AB3641FF13C for ; Thu, 25 Jun 2026 18:41:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 260EC80A; Thu, 25 Jun 2026 18:41:46 +0200 (CEST) From: "Max R. Carrara" To: pve-devel@lists.proxmox.com Subject: [PATCH storage 0/9] Fix ZFS-over-iSCSI plugin w/ LIO Provider Issues Date: Thu, 25 Jun 2026 18:40:52 +0200 Message-ID: <20260625164110.706694-1-m.carrara@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1782405665909 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.070 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lio.pm] Message-ID-Hash: 2J4DPOPT5LO7SBJ5GSNYJF2I47T3RFYO X-Message-ID-Hash: 2J4DPOPT5LO7SBJ5GSNYJF2I47T3RFYO X-MailFrom: m.carrara@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Fix ZFS-over-iSCSI plugin w/ LIO Provider Issues ================================================ When giving the ZFS-over-iSCSI plugin with the LIO iSCSI provider a spin on our test suite, th caching logic in the LIO module causes certain LUNs / ZFS zvols to end up in an inconsistent state -- sometimes. Things I have noticed going wrong are mainly dangling LUNs / zvols -- volumes that were not deleted correctly -- and the plugin sometimes preventing me from creating a new disk for a VM where I just recently deleted a disk, because it thinks the deleted one still exists. The latter scenario fixes itself once the cache is invalidated after 15 seconds, but the former case requires manual fixing on the remote host using `targetcli`. Instead of trying to fix the cache invalidation logic, this series removes the cache altogether, resulting in the plugin running stable even when a lot of operations are being performed. Another issue that may occur is not being able to delete a volume with a "nonstandard" name, e.g.: pvesh create /nodes/localhost/storage/zfs-iscsi-lio/content \ --filename vm-110-disk-2-foo-bar-baz.raw \ --size 4G \ --vmid 110 Note that the main culprit here is actually the '.raw' suffix. For ZFS-over-iSCSI, all volumes and LUNs are usually created in the format of 'vm-100-disk-0', 'vm-420-disk-2', etc. The respective parsing logic is carefully relaxed in this case, allowing such volumes to be deleted again. All of this is addressed in the first three patches. The remaining patches modernize / clean up the code of the LIO module to bring it in line with our contemporary code. This entire series was tested using our test suite while developing it, but some additional testing wouldn't hurt. Summary of Changes ------------------ pve-storage: Max R. Carrara (9): luncmd: lio: fix various errors by removing caching mechanism luncmd: lio: fix LUN ops failing when passing nonstandard LUN path luncmd: lio: remove rest of old parsing logic luncmd: lio: modernize helpers luncmd: lio: modernize & clean up `list_view()` and `list_lun()` subs luncmd: lio: modernize sub `create_lun()` luncmd: lio: modernize sub `delete_lun()` luncmd: lio: modernize remaining LUN command subroutines luncmd: lio: use v5.36 and use subroutine signatures src/PVE/Storage/LunCmd/LIO.pm | 521 ++++++++++++++++------------------ 1 file changed, 243 insertions(+), 278 deletions(-) Summary over all repositories: 1 files changed, 243 insertions(+), 278 deletions(-) -- Generated by murpp 0.11.0