From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A9A1C1FF13C for ; Thu, 25 Jun 2026 13:23:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DC20EE34D; Thu, 25 Jun 2026 13:23:00 +0200 (CEST) From: Shannon Sterz To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox 2/3] http: tls: implement `PartialEq` for `SslVerifyError` Date: Thu, 25 Jun 2026 13:22:35 +0200 Message-ID: <20260625112236.188257-2-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260625112236.188257-1-s.sterz@proxmox.com> References: <20260625112236.188257-1-s.sterz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1782386572653 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.194 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy ENA_SUBJ_ODD_CASE 2.6 Subject has odd case KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: S4J2NR44NFDN7VT53WC3K23DP7M7H2FZ X-Message-ID-Hash: S4J2NR44NFDN7VT53WC3K23DP7M7H2FZ X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: this is useful for writting integration tests, but could also come in handy if such errors ever get propagated to a yew front-end. as yew requires `PartialEq` for `Properties` to implement its re-rendering logic. Signed-off-by: Shannon Sterz --- proxmox-http/src/tls.rs | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/proxmox-http/src/tls.rs b/proxmox-http/src/tls.rs index d7a7aa98..aa77d4cf 100644 --- a/proxmox-http/src/tls.rs +++ b/proxmox-http/src/tls.rs @@ -27,6 +27,35 @@ pub enum SslVerifyError { UntrustedCertificate { fingerprint: String }, } +// Useful for testing. Can't hide it behind `#[cfg(test)]` for integration tests, though. +impl PartialEq for SslVerifyError { + fn eq(&self, other: &Self) -> bool { + match (self, other) { + (SslVerifyError::NoCertificate, SslVerifyError::NoCertificate) => true, + (SslVerifyError::InvalidFingerprint(_), SslVerifyError::InvalidFingerprint(_)) => true, + ( + SslVerifyError::FingerprintMismatch { + fingerprint: a_fingerprint, + expected: a_expected, + }, + SslVerifyError::FingerprintMismatch { + fingerprint: b_fingerprint, + expected: b_expected, + }, + ) => a_fingerprint == b_fingerprint && a_expected == b_expected, + ( + SslVerifyError::UntrustedCertificate { + fingerprint: a_fingerprint, + }, + SslVerifyError::UntrustedCertificate { + fingerprint: b_fingerprint, + }, + ) => a_fingerprint == b_fingerprint, + _ => false, + } + } +} + /// Intended as an openssl verification callback. /// /// If the 'PROXMOX_NEW_TLS_CHECK' environment variable is set to "1", -- 2.47.3