From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A925B1FF13C for ; Thu, 25 Jun 2026 13:23:28 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8858BE676; Thu, 25 Jun 2026 13:23:28 +0200 (CEST) From: Shannon Sterz To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox 1/3] http: tls: move PROXMOX_NEW_TLS_CHECK env var name into constant Date: Thu, 25 Jun 2026 13:22:34 +0200 Message-ID: <20260625112236.188257-1-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1782386570616 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.106 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LELLYOVH74XMQAXVBFZQ2DAPIOYMUO5P X-Message-ID-Hash: LELLYOVH74XMQAXVBFZQ2DAPIOYMUO5P X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: so we can use the constant in integration tests and other users of this crate and have a single place to adapt it. Signed-off-by: Shannon Sterz --- proxmox-http/src/tls.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/proxmox-http/src/tls.rs b/proxmox-http/src/tls.rs index 635b0e7f..d7a7aa98 100644 --- a/proxmox-http/src/tls.rs +++ b/proxmox-http/src/tls.rs @@ -1,5 +1,7 @@ use openssl::x509::{X509StoreContextRef, X509VerifyResult}; +pub const PROXMOX_NEW_TLS_CHECK_VAR: &str = "PROXMOX_NEW_TLS_CHECK"; + /// /// Error type returned by failed [`openssl_verify_callback`]. /// @@ -41,7 +43,7 @@ pub fn openssl_verify_callback( ) -> Result<(), SslVerifyError> { let trust_openssl = ctx.error() != X509VerifyResult::APPLICATION_VERIFICATION; - let new_check = matches!(std::env::var("PROXMOX_NEW_TLS_CHECK").as_deref(), Ok("1")); + let new_check = matches!(std::env::var(PROXMOX_NEW_TLS_CHECK_VAR).as_deref(), Ok("1")); if openssl_valid && trust_openssl { if new_check && expected_fp.is_none() { -- 2.47.3