From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E4D3A1FF146 for ; Tue, 23 Jun 2026 11:45:43 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CF2161DEE9; Tue, 23 Jun 2026 11:45:35 +0200 (CEST) From: Christoph Heiss To: pve-devel@lists.proxmox.com Subject: [PATCH manager 5/7] network-interface-pinning: avoid warning if `bond-primary` is unset Date: Tue, 23 Jun 2026 11:43:22 +0200 Message-ID: <20260623094419.330174-6-c.heiss@proxmox.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260623094419.330174-1-c.heiss@proxmox.com> References: <20260623094419.330174-1-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1782207884963 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.077 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3W2ISRZFLYAFIQRI2FDWDKW3NFBQU5PR X-Message-ID-Hash: 3W2ISRZFLYAFIQRI2FDWDKW3NFBQU5PR X-MailFrom: c.heiss@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Results in warnings such as Use of uninitialized value $iface_name in pattern match (m//) at .. Use of uninitialized value $iface_name in hash element at .. `bond-primary` is an optional property and thus may be unset. Signed-off-by: Christoph Heiss --- PVE/CLI/pve_network_interface_pinning.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/CLI/pve_network_interface_pinning.pm b/PVE/CLI/pve_network_interface_pinning.pm index 9dff181dc..19e358cd9 100644 --- a/PVE/CLI/pve_network_interface_pinning.pm +++ b/PVE/CLI/pve_network_interface_pinning.pm @@ -95,7 +95,8 @@ my sub update_etc_network_interfaces { $iface_name = $mapping->name($iface_name); $iface->{'vlan-raw-device'} = $mapping->name($iface->{'vlan-raw-device'}); } elsif ($iface->{type} eq 'bond') { - $iface->{'bond-primary'} = $mapping->name($iface->{'bond-primary'}); + $iface->{'bond-primary'} = $mapping->name($iface->{'bond-primary'}) + if defined($iface->{'bond-primary'}); $iface->{slaves} = $mapping->list($iface->{slaves}); } elsif ($iface->{type} eq 'bridge') { $iface->{bridge_ports} = $mapping->list($iface->{bridge_ports}); -- 2.54.0