all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH installer] gui: only run next button callback if there is one
Date: Fri, 19 Jun 2026 09:50:32 +0200	[thread overview]
Message-ID: <20260619075041.145045-1-m.sandoval@proxmox.com> (raw)

When testing the GUI installer via `make check-pve` the traceroute
command can time out, during this time the callback is not yet defined
and pressing the Next button will result in warnings in the CLI.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxinstall | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/proxinstall b/proxinstall
index 49b1612..91fcc4a 100755
--- a/proxinstall
+++ b/proxinstall
@@ -165,7 +165,7 @@ sub create_main_window {
     $next_btn->signal_connect(
         clicked => sub {
             Proxmox::Install::reset_last_display_change();
-            $gtk_state->{next_btn_callback}->();
+            $gtk_state->{next_btn_callback}->() if $gtk_state->{next_btn_callback};
         },
     );
     $cmdbox->pack_end($next_btn, 0, 0, 10);
-- 
2.47.3





                 reply	other threads:[~2026-06-19  7:50 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260619075041.145045-1-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal