all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Erik Fastermann <e.fastermann@proxmox.com>
Subject: [PATCH installer] gui: set fill and expand to zero for separator
Date: Fri, 19 Jun 2026 09:38:57 +0200	[thread overview]
Message-ID: <20260619073859.128391-1-m.sandoval@proxmox.com> (raw)

Without this change the separator would both move and grow in size if
the disk setup dialog is resized vertically.

As per gtk_box_pack_end documentation:

> @expand: %TRUE if the new child is to be given extra space allocated
>   to @box. The extra space will be divided evenly between all children
>   of @box that use this option
> @fill: %TRUE if space given to @child by the @expand option is
>   actually allocated to @child, rather than just padding it.  This
>   parameter has no effect if @expand is set to %FALSE [...]

Reported-by: Erik Fastermann <e.fastermann@proxmox.com>
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxinstall | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/proxinstall b/proxinstall
index 49b1612..2a6a7c0 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1646,7 +1646,7 @@ sub create_hdoption_view {
 
     my $sep2 = Gtk3::Separator->new('horizontal');
     $sep2->set_visible(1);
-    $contarea->pack_end($sep2, 1, 1, 10);
+    $contarea->pack_end($sep2, 0, 0, 10);
 
     $dialog->show();
 
-- 
2.47.3





                 reply	other threads:[~2026-06-19  7:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260619073859.128391-1-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=e.fastermann@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal