From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 5D2401FF13F for ; Thu, 18 Jun 2026 13:46:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 35A7B162FF; Thu, 18 Jun 2026 13:46:12 +0200 (CEST) From: Dominik Csapak To: yew-devel@lists.proxmox.com Subject: [PATCH yew-comp] rrd: fix debug mode panic when graph is too narrow Date: Thu, 18 Jun 2026 13:44:41 +0200 Message-ID: <20260618114537.2292990-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3OQAJITERZHUTK2IV62IM76A4JKBJEVY X-Message-ID-Hash: 3OQAJITERZHUTK2IV62IM76A4JKBJEVY X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Yew framework devel list at Proxmox List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: When the graph gets too narrow (e.g. when its width is dynamic and the viewport is narrow), the subtraction here could overflow, leading to a panic in debug mode. getting a negative inner width is not useful anyway, so make the subtraction saturating. Signed-off-by: Dominik Csapak --- not super problematic as in the release mode this will simply overflow instead of panic, but i ran into during development, and fixing it should have no negative impact. src/rrd/graph_space.rs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/rrd/graph_space.rs b/src/rrd/graph_space.rs index cd75177..8728391 100644 --- a/src/rrd/graph_space.rs +++ b/src/rrd/graph_space.rs @@ -123,8 +123,12 @@ impl GraphSpace { fn update_inner_size(&mut self) { let layout = &mut self.layout; - layout.inner_width = layout.width - layout.left_offset - layout.grid_border * 2; - layout.inner_height = layout.height - layout.bottom_offset - layout.grid_border * 2; + layout.inner_width = layout + .width + .saturating_sub(layout.left_offset + layout.grid_border * 2); + layout.inner_height = layout + .height + .saturating_sub(layout.bottom_offset + layout.grid_border * 2); } /// Updates the width of the layout, recalculates all necessary fields -- 2.47.3