From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7ED401FF13F for ; Thu, 18 Jun 2026 13:32:45 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4392615CAD; Thu, 18 Jun 2026 13:32:45 +0200 (CEST) From: Dominik Csapak To: yew-devel@lists.proxmox.com Subject: [PATCH yew-widget-toolkit 2/3] widget: navigation drawer: cleanup menu toggle Date: Thu, 18 Jun 2026 13:31:59 +0200 Message-ID: <20260618113241.2140893-3-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260618113241.2140893-1-d.csapak@proxmox.com> References: <20260618113241.2140893-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: SX5KJBM4MGPT337EGWQET45M3H7SSQUC X-Message-ID-Hash: SX5KJBM4MGPT337EGWQET45M3H7SSQUC X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Yew framework devel list at Proxmox List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: some minor cleanup changes: * use Fa class instead of manual container * use fixed-width for icon (useful when trailing element is just an icon) * drop unnecessary trailing non-breaking space Signed-off-by: Dominik Csapak --- src/widget/nav/navigation_drawer.rs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/widget/nav/navigation_drawer.rs b/src/widget/nav/navigation_drawer.rs index 0066c78..12b4d1e 100644 --- a/src/widget/nav/navigation_drawer.rs +++ b/src/widget/nav/navigation_drawer.rs @@ -16,7 +16,7 @@ use crate::state::{NavigationContext, NavigationContextExt, Selection}; use crate::{impl_class_prop_builder, impl_yew_std_props_builder}; use crate::dom::focus::roving_tabindex_next; -use crate::widget::{Column, Container}; +use crate::widget::{Column, Container, Fa}; use super::{Menu, MenuEntry, MenuItem}; @@ -242,13 +242,12 @@ impl PwtNavigationDrawer { .with_optional_child(item.trailing.clone()) // add optional menu-open icon .with_optional_child(is_menu.then(|| { - Container::from_tag("i") + Fa::new("caret-down") + .fixed_width() .attribute("role", "none") - .class("fa fa-caret-down") .class("pwt-nav-menu-item-arrow") .class(open.then_some("expanded")) .onclick(ontoggle) - .with_child("\u{00a0}") })) .into() } -- 2.47.3