all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Kefu Chai <k.chai@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager 1/1] ui: ceph: config db: auto-show MASK column when masks are in use
Date: Wed, 17 Jun 2026 19:52:29 +0800	[thread overview]
Message-ID: <20260617115229.3763257-2-k.chai@proxmox.com> (raw)
In-Reply-To: <20260617115229.3763257-1-k.chai@proxmox.com>

A mask narrows the scope of a config entry to a subset of daemons
matching a qualifier such as 'class:hdd' or 'host:node1'. Without it
visible, an entry set for 'osd/class:hdd' shows up as 'osd' in the
table, indistinguishable from a setting that applies to all OSDs.

The MASK column existed since the table was introduced but was hidden
in f9bbe5fe to reduce noise: the field is empty for the vast majority
of entries on typical clusters. Exposing it unconditionally would add
an empty column for users who never set any masked options.

Check after the store loads whether any entry has a non-empty mask and
unhide the column only then. On clusters without masked settings the
table is unaffected.

Fixes #6948.

Signed-off-by: Kefu Chai <k.chai@proxmox.com>
---
 www/manager6/ceph/Config.js | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/www/manager6/ceph/Config.js b/www/manager6/ceph/Config.js
index fa2e1b71..0d670e0e 100644
--- a/www/manager6/ceph/Config.js
+++ b/www/manager6/ceph/Config.js
@@ -62,6 +62,13 @@ Ext.define('PVE.node.CephConfigDb', {
 
         me.callParent();
 
+        me.getStore().on('load', function(store) {
+            let hasMask = store.getRange().some(rec => rec.get('mask'));
+            if (hasMask) {
+                me.down('[dataIndex=mask]').setVisible(true);
+            }
+        });
+
         Proxmox.Utils.monStoreErrors(me, me.getStore());
         me.getStore().load();
     },
-- 
2.47.3





      reply	other threads:[~2026-06-17 11:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-17 11:52 [PATCH manager 0/1] ui: ceph: config db: auto-show MASK column when masks are in use Kefu Chai
2026-06-17 11:52 ` Kefu Chai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260617115229.3763257-2-k.chai@proxmox.com \
    --to=k.chai@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal