From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 76CF31FF14C for ; Fri, 12 Jun 2026 17:45:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3B4CE176AC; Fri, 12 Jun 2026 17:45:04 +0200 (CEST) From: Shan Shaji To: yew-devel@lists.proxmox.com Subject: [PATCH proxmox-yew-comp 1/2] fix: user_panel: show confirmation dialog before removing users Date: Fri, 12 Jun 2026 17:44:45 +0200 Message-ID: <20260612154446.364072-2-s.shaji@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260612154446.364072-1-s.shaji@proxmox.com> References: <20260612154446.364072-1-s.shaji@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781279051209 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.150 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: A34OVORDRVBBJVTAJ4DNYQUJEIXTJ2MU X-Message-ID-Hash: A34OVORDRVBBJVTAJ4DNYQUJEIXTJ2MU X-MailFrom: s.shaji@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Yew framework devel list at Proxmox List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Earlier, when pressing 'Remove' inside the user management panel the user was removed without any confirmation. Fixed this by adding the confirmation dialog. Signed-off-by: Shan Shaji --- src/user_panel.rs | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/src/user_panel.rs b/src/user_panel.rs index 75a442f..6903b87 100644 --- a/src/user_panel.rs +++ b/src/user_panel.rs @@ -25,9 +25,9 @@ use crate::form::delete_empty_values; use crate::percent_encoding::percent_encode_component; use crate::utils::{epoch_to_input_value, render_epoch_short}; use crate::{ - EditWindow, LoadableComponent, LoadableComponentContext, LoadableComponentMaster, - LoadableComponentScopeExt, LoadableComponentState, PermissionPanel, RealmSelector, - SchemaValidation, + ConfirmButton, EditWindow, LoadableComponent, LoadableComponentContext, + LoadableComponentMaster, LoadableComponentScopeExt, LoadableComponentState, PermissionPanel, + RealmSelector, SchemaValidation, }; async fn load_user_list() -> Result, Error> { @@ -192,8 +192,9 @@ impl LoadableComponent for ProxmoxUserPanel { let link = ctx.link(); let no_selection = self.selection.is_empty(); - let disable_change_password = self - .get_selected_user() + let selected_user = self.get_selected_user().and_then(|user| Some(user)); + let disable_change_password = selected_user + .as_ref() .and_then(|user| { self.product_realm .as_ref() @@ -216,9 +217,17 @@ impl LoadableComponent for ProxmoxUserPanel { .onclick(link.change_view_callback(|_| Some(ViewState::Edit))), ) .with_child( - Button::new(tr!("Remove")) + ConfirmButton::new(tr!("Remove")) + .dangerous(true) .disabled(no_selection) - .onclick(link.callback(|_| Msg::RemoveItem)), + .confirm_message(match selected_user { + Some(user) => tr!( + "Are you sure you want to remove entry '{}'?", + user.user.userid.as_str() + ), + None => tr!("Are you sure you want to remove this entry?"), + }) + .on_activate(link.callback(|_| Msg::RemoveItem)), ) .with_spacer() .with_child( -- 2.47.3