From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 59C941FF13C for ; Thu, 11 Jun 2026 14:03:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6E8D43588; Thu, 11 Jun 2026 14:03:37 +0200 (CEST) From: Shannon Sterz To: pdm-devel@lists.proxmox.com Subject: [PATCH datacenter-manager 07/17] client: allow users to update a changed fingerprint interactively Date: Thu, 11 Jun 2026 14:03:17 +0200 Message-ID: <20260611120327.257523-8-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260611120327.257523-1-s.sterz@proxmox.com> References: <20260611120327.257523-1-s.sterz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781179364270 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.109 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3PV3QURPMJCFED3UJJS3KEVFHGW3ORIT X-Message-ID-Hash: 3PV3QURPMJCFED3UJJS3KEVFHGW3ORIT X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: if the client is operating in interactive mode and we notice that the certificate of a remote has changed, the client now asks the user whether the certificate should be updated. Signed-off-by: Shannon Sterz --- cli/client/src/env/fingerprint_cache.rs | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/cli/client/src/env/fingerprint_cache.rs b/cli/client/src/env/fingerprint_cache.rs index af48c353..a4766ae9 100644 --- a/cli/client/src/env/fingerprint_cache.rs +++ b/cli/client/src/env/fingerprint_cache.rs @@ -137,16 +137,19 @@ impl FingerprintCache { }; if let Some(stored_fp) = self.entries.read().unwrap().get(hostname) { - return Ok(VerifyResult::unmodified(**stored_fp == *fp)); + if self.interactive && **stored_fp != *fp { + println!("Certificate fingerprint has changed!"); + println!("Old certificate SHA256 fingerprint: {stored_fp}"); + } else { + return Ok(VerifyResult::unmodified(**stored_fp == *fp)); + } + } else if !self.interactive || valid { + return Ok(VerifyResult::unmodified(valid)); } let fp = Fingerprint::try_from(&*fp) .map_err(|_| format_err!("unexpected fingerprint length"))?; - if !self.interactive || valid { - return Ok(VerifyResult::unmodified(valid)); - } - println!("Certificate SHA256 fingerprint: {fp}"); let mut stdout = std::io::stdout(); -- 2.47.3