From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id BBDB41FF13C for ; Thu, 11 Jun 2026 14:04:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 754473C3F; Thu, 11 Jun 2026 14:04:06 +0200 (CEST) From: Shannon Sterz To: pdm-devel@lists.proxmox.com Subject: [PATCH manager 03/17] api: certificates: if node parameter is 'localhost' return local certs Date: Thu, 11 Jun 2026 14:03:13 +0200 Message-ID: <20260611120327.257523-4-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260611120327.257523-1-s.sterz@proxmox.com> References: <20260611120327.257523-1-s.sterz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781179363896 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.109 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [certificates.pm] Message-ID-Hash: 2SCKLJ7WCEERCJG7OIKPS4QZTT75LP4N X-Message-ID-Hash: 2SCKLJ7WCEERCJG7OIKPS4QZTT75LP4N X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: this aligns with many other api endpoints under `/nodes` where `localhost` means "act as if i specified the node that is currently handling this API request". previously this would only return the ca certificate, as that's the only one that had the same path on all nodes. Signed-off-by: Shannon Sterz --- PVE/API2/Certificates.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Certificates.pm b/PVE/API2/Certificates.pm index bcd650c3b..732f98829 100644 --- a/PVE/API2/Certificates.pm +++ b/PVE/API2/Certificates.pm @@ -66,7 +66,10 @@ __PACKAGE__->register_method({ code => sub { my ($param) = @_; - my $node_path = "/etc/pve/nodes/$param->{node}"; + my $node = extract_param($param, 'node'); + $node = PVE::INotify::nodename() if $node eq 'localhost'; + + my $node_path = "/etc/pve/nodes/$node"; my $res = []; my $cert_paths = [ -- 2.47.3