all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [PATCH pmg-api] fix missing postfix welcomelist update
Date: Wed, 10 Jun 2026 09:39:16 +0200	[thread overview]
Message-ID: <20260610074043.501612-1-d.csapak@proxmox.com> (raw)

Similar fix as
 17f17bc (config: do not shortcircuit smtp-welcomelist generation)

If `$changes` is already true, 'rewrite_postfix_welcomelist' will never
called.

This prevented those file generation on first boot after a fresh
install.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
I tested the previous fix only after rebooting the machine, not on a new
installation so I missed this.

This time I installed fresh (in debug mode) and injected the changes
into the file after the installation finished, but before a reboot and
it worked now. Sorry, I could have caught this the first time around...

 src/PMG/Config.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PMG/Config.pm b/src/PMG/Config.pm
index f48c31d..9b22b67 100644
--- a/src/PMG/Config.pm
+++ b/src/PMG/Config.pm
@@ -1916,7 +1916,7 @@ sub rewrite_config_postfix {
     postmap_tls_policy();
     postmap_tls_inbound_domains();
 
-    $changes ||= rewrite_postfix_welcomelist($rulecache) if $rulecache;
+    $changes = 1 if $rulecache && rewrite_postfix_welcomelist($rulecache);
 
     # make sure aliases.db is up to date
     system('/usr/bin/newaliases');
-- 
2.47.3





             reply	other threads:[~2026-06-10  7:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-10  7:39 Dominik Csapak [this message]
2026-06-10  9:00 ` applied: [PATCH pmg-api] fix missing postfix welcomelist update Stoiko Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260610074043.501612-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal