all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Shannon Sterz <s.sterz@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Subject: partially-applied: [PATCH many v6 0/3] fix #5076: add support for open id audiences
Date: Tue, 9 Jun 2026 15:17:09 +0200	[thread overview]
Message-ID: <20260609151709.082e0004@rosa.proxmox.com> (raw)
In-Reply-To: <20260609122214.271422-1-s.sterz@proxmox.com>

Thanks for tackling this and the quick iteration!

I applied the patch for pmg-api (2/3) and for pmg-gui (3/3):

[2/3] fix #5076: auth: openid: add support for an optional "audiences" field
      commit: 7b72b62dfbb68e36133b1eac50d37579fe011e67

[3/3] fix #5076: auth edit open id: add an optional audiences field
      commit: c13eadb0814dc95894ce79ada90961d7f1cbbe2b

On Tue,  9 Jun 2026 14:22:11 +0200
Shannon Sterz <s.sterz@proxmox.com> wrote:

> this series adapts the original patch series by Alexander Abraham [1]. below is
> the text of the original cover letter:
> 
> > fix #5076: Added Open ID audiences
> >
> > This series adds support for handling Open ID audiences as described in bug
> > #5076. PVE's API schema was updated to accept an optional field, an array of
> > strings and the Rust code was also updated to accordingly handle any incoming
> > audiences and compare them to the realm config's audiences. In the realm
> > dialogue for adding an Open ID realm, a new field titled "Audiences" was added
> > so that users can save any audiences in their realm domains config file.  
> 
> essentially, some open id providers such as zitadel [2] may provide additional
> audiences that their id tokens are valid for instead of just the client id.
> these patches allow setting such additional audiences. if an audience that is
> not explicitly allowed is encountered, the id token is rejected as before.
> 
> Changelog
> ---------
> 
> changes since v5:
> 
> * fix up an issue affecting the pmg patches regarding a false variable name
> (thanks @ Stoiko Ivanov)
> * drop patches that have already been applied
> 
> changes since v4:
> 
> * add patches to support audiences in proxmox-backup and
>   proxmox-datacenter-manager as well
> * instead of the api type and configs taking an array, it will now take a string
>   that is a list of audiences. this is more consistent with other parameters 
>   here.
> * rebased on current master.
> 
> changes since v3:
> 
> * rebased on current master
> * see the list of changes made by Shannon Sterz specified in each commit message
> 
> [1]: https://lore.proxmox.com/pve-devel/20250603091256.40923-1-a.abraham@proxmox.com/
> [2]: https://zitadel.com/
> 
> 
> widget-toolkit:
> 
> Shannon Sterz (1):
>   fix #5076: ui: dc: add an optional "audiences" field for open id
>     realms
> 
>  src/window/AuthEditOpenId.js | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> 
> pmg-api:
> 
> Shannon Sterz (1):
>   fix #5076: auth: openid: add support for an optional "audiences" field
> 
>  src/PMG/API2/OIDC.pm | 4 ++++
>  src/PMG/Auth/OIDC.pm | 9 +++++++++
>  2 files changed, 13 insertions(+)
> 
> 
> pmg-api:
> 
> Shannon Sterz (1):
>   fix #5076: auth edit open id: add an optional audiences field
> 
>  js/AuthEditOIDC.js | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> 
> Summary over all repositories:
>   4 files changed, 31 insertions(+), 0 deletions(-)
> 





      parent reply	other threads:[~2026-06-09 13:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-09 12:22 [PATCH many v6 0/3] fix #5076: add support for open id audiences Shannon Sterz
2026-06-09 12:22 ` [PATCH widget-toolkit v6 1/3] fix #5076: ui: dc: add an optional "audiences" field for open id realms Shannon Sterz
2026-06-09 12:22 ` [PATCH pmg-api v6 2/3] fix #5076: auth: openid: add support for an optional "audiences" field Shannon Sterz
2026-06-09 12:22 ` [PATCH pmg-gui v6 3/3] fix #5076: auth edit open id: add an optional audiences field Shannon Sterz
2026-06-09 13:17 ` Stoiko Ivanov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260609151709.082e0004@rosa.proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    --cc=s.sterz@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal