all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server 4/4] block job: mirror: use correct unit for logging bandwidth limit
Date: Tue,  9 Jun 2026 16:28:49 +0200	[thread overview]
Message-ID: <20260609142858.1063820-5-f.ebner@proxmox.com> (raw)
In-Reply-To: <20260609142858.1063820-1-f.ebner@proxmox.com>

The $bwlimit option is multipled by 1024, so it's KiB, not KB.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/QemuServer/BlockJob.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/QemuServer/BlockJob.pm b/src/PVE/QemuServer/BlockJob.pm
index c8b0b030..921f046c 100644
--- a/src/PVE/QemuServer/BlockJob.pm
+++ b/src/PVE/QemuServer/BlockJob.pm
@@ -261,7 +261,7 @@ my sub common_mirror_qmp_options {
 
     if (defined($bwlimit)) {
         $opts->{speed} = $bwlimit * 1024;
-        print "drive mirror is starting for $device_id with bandwidth limit: ${bwlimit} KB/s\n";
+        print "drive mirror is starting for $device_id with bandwidth limit: ${bwlimit} KiB/s\n";
     } else {
         print "drive mirror is starting for $device_id\n";
     }
-- 
2.47.3





      parent reply	other threads:[~2026-06-09 14:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-09 14:28 [PATCH-SERIES guest-common/qemu-server 0/4] remote migration (and drive mirror) improvements Fiona Ebner
2026-06-09 14:28 ` [PATCH guest-common 1/4] storage tunnel: query disk import: adapt to current signature for file_size_info() Fiona Ebner
2026-06-09 14:28 ` [PATCH guest-common 2/4] storage tunnel: disk migration: bump timeout for image check after import Fiona Ebner
2026-06-09 14:28 ` [PATCH qemu-server 3/4] remote migration: mtunnel: avoid warning from superfluous call for removing dbus-vmstate Fiona Ebner
2026-06-09 14:28 ` Fiona Ebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260609142858.1063820-5-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal