all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup 2/2] prune job: escalate keep-all from info to warning
Date: Mon,  8 Jun 2026 10:59:19 +0200	[thread overview]
Message-ID: <20260608085919.288332-3-c.ebner@proxmox.com> (raw)
In-Reply-To: <20260608085919.288332-1-c.ebner@proxmox.com>

While it can make sense to create a prune job without keep options
for testing a schedule, such a scheduled prune task which does
prune nothing should be considered a misconfiguration for normal
operation. As promoting to an error would also trigger notifications
and more dramatically flag the job in the task list, promote to a
warning only. By this it can be easily noticed even without breaking
current error notification behaviour.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 src/server/prune_job.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/server/prune_job.rs b/src/server/prune_job.rs
index 03661127e..afb76c4f8 100644
--- a/src/server/prune_job.rs
+++ b/src/server/prune_job.rs
@@ -38,7 +38,7 @@ pub fn prune_datastore(
     let keep_all = !prune_options.keeps_something();
 
     if keep_all {
-        info!("No prune selection - keeping all files.");
+        warn!("No prune selection - keeping all files.");
     } else {
         let rendered_options = cli_prune_options_string(&prune_options);
         info!("retention options: {rendered_options}");
-- 
2.47.3





      parent reply	other threads:[~2026-06-08  9:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-08  8:59 [PATCH proxmox-backup 0/2] schedule prunes even with keep-all Christian Ebner
2026-06-08  8:59 ` [PATCH proxmox-backup 1/2] proxy: scheduler: drop early return for keep-all prune jobs Christian Ebner
2026-06-08  8:59 ` Christian Ebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260608085919.288332-3-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal