From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 1BEB11FF142 for ; Fri, 05 Jun 2026 17:42:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E92891FBB3; Fri, 5 Jun 2026 17:42:16 +0200 (CEST) From: Erik Fastermann To: pve-devel@lists.proxmox.com Subject: [PATCH pve-common] json schema: display nested oneOf error messages Date: Fri, 5 Jun 2026 17:42:12 +0200 Message-ID: <20260605154212.269658-1-e.fastermann@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.019 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: GQMRC7GDQQGQVAD7V6ZZDXCK2CESM4S4 X-Message-ID-Hash: GQMRC7GDQQGQVAD7V6ZZDXCK2CESM4S4 X-MailFrom: efastermann@ruth.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Erik Fastermann X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Correctly display the error message for each oneOf case, not just the empty string, which was caused by the wrong key being used in the hash lookup. Signed-off-by: Erik Fastermann --- src/PVE/JSONSchema.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm index 1997c70..fd10338 100644 --- a/src/PVE/JSONSchema.pm +++ b/src/PVE/JSONSchema.pm @@ -1409,13 +1409,13 @@ sub check_prop { } for my $inner_path (keys $inner_errors->%*) { - add_error($collected_errors, $inner_path, $inner_errors->{$path}); + add_error($collected_errors, $inner_path, $inner_errors->{$inner_path}); } } if (!$is_valid) { for my $inner_path (keys $collected_errors->%*) { - add_error($errors, $inner_path, $collected_errors->{$path}); + add_error($errors, $inner_path, $collected_errors->{$inner_path}); } } } -- 2.47.3