From: "Michael Köppl" <m.koeppl@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH cluster v4 3/8] add functions to determine warning level for high token timeouts
Date: Fri, 5 Jun 2026 17:38:14 +0200 [thread overview]
Message-ID: <20260605153819.310048-4-m.koeppl@proxmox.com> (raw)
In-Reply-To: <20260605153819.310048-1-m.koeppl@proxmox.com>
High token timeouts can lead to stability problems in clusters. To
inform users about the timeout in their current setup and give
recommendations regarding the token coefficient setting, introduce
functions to calculate the timeout as well as determine the warning
level.
Current token and consensus timeout are parsed from corosync-cmapctl's
output directly to avoid future drift between this implementation and
Corosync's implementation. The values are parsed from the output
assuming the following format:
runtime.config.totem.consensus (u32) = 3750
runtime.config.totem.token (u32) = 3125
Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
src/PVE/Corosync.pm | 59 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 59 insertions(+)
diff --git a/src/PVE/Corosync.pm b/src/PVE/Corosync.pm
index aef0d31..d379710 100644
--- a/src/PVE/Corosync.pm
+++ b/src/PVE/Corosync.pm
@@ -534,4 +534,63 @@ sub resolve_hostname_like_corosync {
return $match_ip_and_version->($resolved_ip);
}
+sub read_cmap {
+ my $cmap = {};
+ my $rc = eval {
+ PVE::Tools::run_command(
+ ['corosync-cmapctl'],
+ outfunc => sub {
+ my $line = shift;
+ if ($line =~ /^(\S+)\s+\(\w+\)\s+=\s+(.*)$/) {
+ $cmap->{$1} = $2;
+ }
+ },
+ );
+ 1;
+ };
+ return undef if !$rc;
+ return $cmap;
+}
+
+sub calculate_membership_recovery_timeout {
+ my $cmap = read_cmap();
+ return undef if !$cmap;
+
+ my $token = $cmap->{'runtime.config.totem.token'};
+ my $consensus = $cmap->{'runtime.config.totem.consensus'};
+ return undef if !defined($token) || !defined($consensus);
+
+ return ($token + $consensus) / 1000.0;
+}
+
+sub get_membership_recovery_timeout_warning_level {
+ my ($total_timeout_secs) = @_;
+
+ if ($total_timeout_secs > 45) {
+ return 'critical';
+ } elsif ($total_timeout_secs > 40) {
+ return 'warning';
+ } elsif ($total_timeout_secs > 30) {
+ return 'info';
+ }
+
+ return undef;
+}
+
+sub get_membership_recovery_timeout_warning {
+ my ($total_timeout_secs) = @_;
+
+ my $level = get_membership_recovery_timeout_warning_level($total_timeout_secs);
+ return if !defined($level);
+
+ my $level_msg = {
+ critical => "Lowering the token coefficient is strongly recommended",
+ warning => "Lowering the token coefficient is recommended",
+ info => "The token coefficient can be optimized",
+ }->{$level};
+
+ my $msg = "Sum of Corosync token and consensus timeout is ${total_timeout_secs}s. $level_msg.";
+ return ($level, $msg);
+}
+
1;
--
2.47.3
next prev parent reply other threads:[~2026-06-05 15:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-05 15:38 [PATCH cluster/docs/manager/widget-toolkit v4 0/8] add warning messages for high token timeouts in clusters Michael Köppl
2026-06-05 15:38 ` [PATCH docs v4 1/8] asciidoc-pve: allow linking sections with get_help_link Michael Köppl
2026-06-05 15:38 ` [PATCH docs v4 2/8] pvecm: add info about warnings regarding token coefficient Michael Köppl
2026-06-05 15:38 ` Michael Köppl [this message]
2026-06-05 15:38 ` [PATCH cluster v4 4/8] pvecm: warn users of high token timeouts when using status command Michael Köppl
2026-06-05 15:38 ` [PATCH cluster v4 5/8] api: join info: add totem timeout warning message and level Michael Köppl
2026-06-05 15:38 ` [PATCH widget-toolkit v4 6/8] add pmx-critical CSS class Michael Köppl
2026-06-05 15:38 ` [PATCH manager v4 7/8] ui: cluster info: move initialization of items to initComponent Michael Köppl
2026-06-05 15:38 ` [PATCH manager v4 8/8] ui: cluster info: display warnings from the join info endpoint Michael Köppl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260605153819.310048-4-m.koeppl@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.