From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 31CE51FF13B for ; Wed, 03 Jun 2026 20:05:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C201B15A33; Wed, 3 Jun 2026 20:05:30 +0200 (CEST) From: Stoiko Ivanov To: pmg-devel@lists.proxmox.com Subject: [PATCH pve-common 01/15] pbs-client: autogen key: rename old one if existing Date: Wed, 3 Jun 2026 20:03:03 +0200 Message-ID: <20260603180445.98770-2-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260603180445.98770-1-s.ivanov@proxmox.com> References: <20260603180445.98770-1-s.ivanov@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1780509859309 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.088 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YUMXIAGORGSEF3LM6QHGMCG6WKWGNWQD X-Message-ID-Hash: YUMXIAGORGSEF3LM6QHGMCG6WKWGNWQD X-MailFrom: s.ivanov@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: while looking into adding encryption support for PMG, I noticed the discrepancy between PVE::Storage::PBSPlugin and PVE::PBSClient Semantically this follows: 478609d ("pbs: autogen key: rename old one if existing") in pve-storage. Signed-off-by: Stoiko Ivanov --- src/PVE/PBSClient.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/PVE/PBSClient.pm b/src/PVE/PBSClient.pm index 5af0d00..d8dd3f0 100644 --- a/src/PVE/PBSClient.pm +++ b/src/PVE/PBSClient.pm @@ -238,6 +238,9 @@ my sub run_client_cmd : prototype($$;$$$$) { sub autogen_encryption_key { my ($self) = @_; my $encfile = $self->encryption_key_file_name(); + if (-f $encfile) { + rename $encfile, "$encfile.old"; + } run_command( ['proxmox-backup-client', 'key', 'create', '--kdf', 'none', $encfile], errmsg => 'failed to create encryption key', -- 2.47.3