all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Nicolas Frey <n.frey@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH proxmox 0/2] fix #7541: zfs status: account for msg directly after status in vdev parser
Date: Wed,  3 Jun 2026 17:58:20 +0200	[thread overview]
Message-ID: <20260603155822.370223-1-n.frey@proxmox.com> (raw)

As reported in Enterprise Support, when a spare is "INUSE", it has a
`msg` right after the STATUS, which the parser previously did not
account for.

This patch-series was previously for PBS, but as proxmox-disks is
factoring that code out, it makes sense to make the change here.
I reckon as PBS will at some point use proxmox-disks, it's fine to
only fix this parser issue here; though please let me know if this
fix should also be seperately done again for PBS.

It also doesn't quite 'fix' the bug mentioned in the second patch, as
PBS doesn't use proxmox-disks yet.

Changes since PBS version:
* simplify parsing logic by optionally parsing out the stats resulting
  in a single return and msg parse. This way there is no "special case"

proxmox:

Nicolas Frey (2):
  disks: zpool: add `VDevStats` struct instead of 3 optional u64s
  fix #7541: zfs status: account for msg directly after status in vdev
    parser

 proxmox-disks/src/zpool_status.rs | 53 ++++++++++++-------------------
 1 file changed, 21 insertions(+), 32 deletions(-)


Summary over all repositories:
  1 files changed, 21 insertions(+), 32 deletions(-)

--
Generated by murpp 0.12.0



             reply	other threads:[~2026-06-03 15:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-03 15:58 Nicolas Frey [this message]
2026-06-03 15:58 ` [PATCH proxmox 1/2] disks: zpool: add `VDevStats` struct instead of 3 optional u64s Nicolas Frey
2026-06-03 15:58 ` [PATCH proxmox 2/2] fix #7541: zfs status: account for msg directly after status in vdev parser Nicolas Frey
2026-06-03 16:01 ` [PATCH proxmox 0/2] " Nicolas Frey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260603155822.370223-1-n.frey@proxmox.com \
    --to=n.frey@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal