all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH-SERIES qemu-server 0/2] partially fix #7554: avoid incorrectly offline migrating qcow2 on LVM as raw
Date: Mon,  1 Jun 2026 16:55:00 +0200	[thread overview]
Message-ID: <20260601145528.285536-1-f.ebner@proxmox.com> (raw)

Because volumes were not activated early for offline migration,
getting the size and as a consequence the format would not work for
qcow2 on LVM. But migration also continued and not having the format
would lead to the 'with-snapshots' parameter not being set, despite
the format being qcow2 and so the migration would wrongly continue
with raw+size as the stream format. If 'with-snapshots' were set, the
plugin would correctly report that there is no possible transfer
format (the same restriction is present in file-based storages with
snapshot-as-volume-chain).

Fix the issue by activating the volumes early, as well as failing when
the size and format cannot be determined as an additional guardrail.

What could still be implemented is migrating as qcow2+size when there
actually are no snapshots.

qemu-server:

Fiona Ebner (2):
  migration: local volume: abort early when size or format cannot be
    determined
  migration: local volume: activate for querying the size (required for
    qcow2 on LVM)

 src/PVE/QemuMigrate.pm | 6 ++++++
 1 file changed, 6 insertions(+)


Summary over all repositories:
  1 files changed, 6 insertions(+), 0 deletions(-)

-- 
Generated by git-murpp 0.5.0




             reply	other threads:[~2026-06-01 14:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01 14:55 Fiona Ebner [this message]
2026-06-01 14:55 ` [PATCH qemu-server 1/2] migration: local volume: abort early when size or format cannot be determined Fiona Ebner
2026-06-01 14:55 ` [PATCH qemu-server 2/2] migration: local volume: activate for querying the size (required for qcow2 on LVM) Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260601145528.285536-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal