From: Jakob Klocker <j.klocker@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Jakob Klocker <j.klocker@proxmox.com>
Subject: [PATCH manager 2/3] fix #7513: api: certs: change ACL on certificates path
Date: Thu, 28 May 2026 13:35:03 +0200 [thread overview]
Message-ID: <20260528113505.12961-3-j.klocker@proxmox.com> (raw)
In-Reply-To: <20260528113505.12961-1-j.klocker@proxmox.com>
Endpoints under /nodes/{node}/certificates/* required
/nodes/{node} permission. To allow least-privileged for certification
changes, check the permissions on /nodes/{node}/certificates path
instead.
Link: https://bugzilla.proxmox.com/show_bug.cgi?id=7513
Signed-off-by: Jakob Klocker <j.klocker@proxmox.com>
---
PVE/API2/ACME.pm | 6 +++---
PVE/API2/Certificates.pm | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/PVE/API2/ACME.pm b/PVE/API2/ACME.pm
index a948a72a..3f6679a0 100644
--- a/PVE/API2/ACME.pm
+++ b/PVE/API2/ACME.pm
@@ -160,7 +160,7 @@ __PACKAGE__->register_method({
path => 'certificate',
method => 'POST',
permissions => {
- check => ['perm', '/nodes/{node}', ['Sys.Modify']],
+ check => ['perm', '/nodes/{node}/certificates', ['Sys.Modify']],
},
description => "Order a new certificate from ACME-compatible CA.",
protected => 1,
@@ -232,7 +232,7 @@ __PACKAGE__->register_method({
path => 'certificate',
method => 'PUT',
permissions => {
- check => ['perm', '/nodes/{node}', ['Sys.Modify']],
+ check => ['perm', '/nodes/{node}/certificates', ['Sys.Modify']],
},
description => "Renew existing certificate from CA.",
protected => 1,
@@ -319,7 +319,7 @@ __PACKAGE__->register_method({
path => 'certificate',
method => 'DELETE',
permissions => {
- check => ['perm', '/nodes/{node}', ['Sys.Modify']],
+ check => ['perm', '/nodes/{node}/certificates', ['Sys.Modify']],
},
description => "Revoke existing certificate from CA.",
protected => 1,
diff --git a/PVE/API2/Certificates.pm b/PVE/API2/Certificates.pm
index de8762c5..8da1e93b 100644
--- a/PVE/API2/Certificates.pm
+++ b/PVE/API2/Certificates.pm
@@ -87,7 +87,7 @@ __PACKAGE__->register_method({
path => 'custom',
method => 'POST',
permissions => {
- check => ['perm', '/nodes/{node}', ['Sys.Modify']],
+ check => ['perm', '/nodes/{node}/certificates', ['Sys.Modify']],
},
description => 'Upload or update custom certificate chain and key.',
protected => 1,
@@ -165,7 +165,7 @@ __PACKAGE__->register_method({
path => 'custom',
method => 'DELETE',
permissions => {
- check => ['perm', '/nodes/{node}', ['Sys.Modify']],
+ check => ['perm', '/nodes/{node}/certificates', ['Sys.Modify']],
},
description => 'DELETE custom certificate chain and key.',
protected => 1,
--
2.47.3
next prev parent reply other threads:[~2026-05-28 11:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 11:35 [PATCH manager/access-control 0/3] fix #7513: fine-grained ACL for node certificates Jakob Klocker
2026-05-28 11:35 ` [PATCH access-control 1/3] fix #7513: acl: allow ACL access to /nodes/{node}/certificates path Jakob Klocker
2026-05-28 11:35 ` Jakob Klocker [this message]
2026-05-28 11:35 ` [PATCH manager 3/3] fix #7513: ui: perm path store: add per-node certificates ACL path Jakob Klocker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260528113505.12961-3-j.klocker@proxmox.com \
--to=j.klocker@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.