From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 3C8F31FF13C for ; Thu, 28 May 2026 13:36:51 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 92BA8150E8; Thu, 28 May 2026 13:36:45 +0200 (CEST) From: Jakob Klocker To: pve-devel@lists.proxmox.com Subject: [PATCH access-control 1/3] fix #7513: acl: allow ACL access to /nodes/{node}/certificates path Date: Thu, 28 May 2026 13:35:02 +0200 Message-ID: <20260528113505.12961-2-j.klocker@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260528113505.12961-1-j.klocker@proxmox.com> References: <20260528113505.12961-1-j.klocker@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.075 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: HPFTFZ5CORHKEGZTDSZJTB2Q4MP3ZHEP X-Message-ID-Hash: HPFTFZ5CORHKEGZTDSZJTB2Q4MP3ZHEP X-MailFrom: root@dev.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Jakob Klocker X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Currently access to /nodes/{node}/certificates requires /nodes/{node} rights, this doesn't follow least-privilege best practice. Instead of introducing a specific privilege, allow ACL access to /nodes/{node}/certificates. Link: https://bugzilla.proxmox.com/show_bug.cgi?id=7513 Signed-off-by: Jakob Klocker --- src/PVE/AccessControl.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/AccessControl.pm b/src/PVE/AccessControl.pm index 0d632b3..f005786 100644 --- a/src/PVE/AccessControl.pm +++ b/src/PVE/AccessControl.pm @@ -1289,6 +1289,7 @@ sub check_path { |/access/realm/[[:alnum:]\.\-\_]+ |/nodes |/nodes/[[:alnum:]\.\-\_]+ + |/nodes/[[:alnum:]\.\-\_]+/certificates |/pool |/pool/[A-Za-z0-9\.\-_]+(?:/[A-Za-z0-9\.\-_]+){0,2} |/sdn -- 2.47.3