all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-network] ui: sdn: wireguard: clarify peer grid and endpoint labels
Date: Tue, 26 May 2026 09:04:38 +0200	[thread overview]
Message-ID: <20260526070438.18120-1-h.laimer@proxmox.com> (raw)

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
this should make it more explicit and help if someone is not already
familiar with what fields are for, and what setting them means

 www/manager6/sdn/fabrics/wireguard/InterfacePanel.js | 4 ++++
 www/manager6/sdn/fabrics/wireguard/NodeEdit.js       | 8 +++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/www/manager6/sdn/fabrics/wireguard/InterfacePanel.js b/www/manager6/sdn/fabrics/wireguard/InterfacePanel.js
index 80fe6919..1bd1c79b 100644
--- a/www/manager6/sdn/fabrics/wireguard/InterfacePanel.js
+++ b/www/manager6/sdn/fabrics/wireguard/InterfacePanel.js
@@ -372,6 +372,10 @@ Ext.define('PVE.sdn.Fabric.WireGuard.InterfacePanel', {
                     xtype: 'pveSDNWireGuardPeerSelector',
                     reference: 'peerSelector',
                     bind: {
+                        title: Ext.String.format(
+                            gettext('Peers of {0}'),
+                            '{selectedInterface.name}',
+                        ),
                         currentNode: '{currentNode}',
                         availablePeers: '{availablePeers}',
                         selectedPeers: '{selectedInterface.peers}',
diff --git a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js b/www/manager6/sdn/fabrics/wireguard/NodeEdit.js
index fe4639ad..6d51034a 100644
--- a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js
+++ b/www/manager6/sdn/fabrics/wireguard/NodeEdit.js
@@ -24,6 +24,10 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', {
                 let me = this;
                 return !me.getView().isCreate || get('current.isPveNode');
             },
+            endpointEmptyText: (get) =>
+                get('current.isPveNode')
+                    ? gettext('Host that peers connect to')
+                    : gettext('host:port this external node is reachable at'),
         },
     },
 
@@ -58,10 +62,12 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', {
         {
             xtype: 'proxmoxtextfield',
             fieldLabel: gettext('Endpoint'),
-            emptyText: gettext('Host that peers connect to'),
             labelWidth: 120,
             name: 'endpoint',
             allowBlank: false,
+            bind: {
+                emptyText: '{endpointEmptyText}',
+            },
         },
         {
             xtype: 'proxmoxtextfield',
-- 
2.47.3





                 reply	other threads:[~2026-05-26  7:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260526070438.18120-1-h.laimer@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal