all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager 2/2] ui: vCPU flag selector: re-enable sortable columns
Date: Mon, 25 May 2026 15:15:26 +0200	[thread overview]
Message-ID: <20260525131839.1720731-3-t.lamprecht@proxmox.com> (raw)
In-Reply-To: <20260525131839.1720731-1-t.lamprecht@proxmox.com>

The preceding commit replaced the radio widgets, whose inputs went
stale in reordered rows, with segmented buttons that re-sync on widget
attach. As that was the only reason sorting was disabled as a
stop-gap, we can drop that again.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
 www/manager6/form/VMCPUFlagSelector.js | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js
index 5972ee678..9cd076166 100644
--- a/www/manager6/form/VMCPUFlagSelector.js
+++ b/www/manager6/form/VMCPUFlagSelector.js
@@ -4,9 +4,6 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
 
     bufferedRenderer: false,
 
-    // FIXME: stop-gap; sorting caused glitches with the inputs of radio widgets in moved rows.
-    sortableColumns: false,
-
     mixins: {
         field: 'Ext.form.field.Field',
     },
-- 
2.47.3





  parent reply	other threads:[~2026-05-25 13:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-25 13:15 [PATCH manager 0/2] ui: vCPU flag editor: switch radio group approach to segmented button Thomas Lamprecht
2026-05-25 13:15 ` [PATCH manager 1/2] ui: vCPU flag selector: replace radio group with " Thomas Lamprecht
2026-05-26  6:02   ` Arthur Bied-Charreton
2026-05-25 13:15 ` Thomas Lamprecht [this message]
2026-05-26  5:49   ` [PATCH manager 2/2] ui: vCPU flag selector: re-enable sortable columns Arthur Bied-Charreton
2026-05-29  7:33 ` applied: [PATCH manager 0/2] ui: vCPU flag editor: switch radio group approach to segmented button Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260525131839.1720731-3-t.lamprecht@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal