Re: [PATCH v2 storage 06/15] iscsi: change functions to handle mappings

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On Thu, 30 Apr 2026 19:27:04 +0200, Mira Limbeck wrote:
> diff --git a/src/PVE/Storage/ISCSIPlugin.pm b/src/PVE/Storage/ISCSIPlugin.pm
> @@ -654,18 +679,26 @@ sub activate_volume {
>      my $device_path = $udev_query_path->($real_path);
>      my $resolved_paths = $resolve_virtual_devices->($device_path);
>
> -    my $found = $check_devices_part_of_target->($resolved_paths, $scfg->{target});
> -    die "volume '$volname' not part of target '$scfg->{target}'\n" if !$found;
> +    my $local_cfg = $get_local_config->($scfg);
> +    my $found = 0;
> +    for my $target ($local_cfg->{targets}->%*) {
> +        $found ||= $check_devices_part_of_target->($resolved_paths, $target);
> +        last if $found;
> +    }
> +    die "volume '$volname' not part of any matching target\n" if !$found;

Missing `keys`: ->%* in list context flattens to (target, portals-arrayref,
...), so $target also takes the arrayref values and
$check_devices_part_of_target then compares a targetname against an
arrayref. Works by accident for a single target. check_connection() in this
same patch uses `keys` correctly - i.e.:

  -    for my $target ($local_cfg->{targets}->%*) {
  +    for my $target (keys $local_cfg->{targets}->%*) {