From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E5E5E1FF13B for ; Wed, 20 May 2026 07:26:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 01918189FD; Wed, 20 May 2026 07:26:26 +0200 (CEST) From: Arthur Bied-Charreton To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager] ui: custom cpu models view: disable edits if missing permissions Date: Wed, 20 May 2026 07:25:52 +0200 Message-ID: <20260520052552.72701-1-a.bied-charreton@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.134 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: 5K7FLSYRQGRNQ2UXT37YBOBSZSIBLWSE X-Message-ID-Hash: 5K7FLSYRQGRNQ2UXT37YBOBSZSIBLWSE X-MailFrom: abied-charreton@jett.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Until now, the custom CPU models view would let a user lacking Mapping.Modify permissions go through the whole custom model creation/edit flow and only fail on submit. Disable the buttons if the user lacks the required permissions. Reported-by: Michael Köppl Signed-off-by: Arthur Bied-Charreton --- www/manager6/dc/CPUTypeView.js | 62 ++++++++++++++++++---------------- 1 file changed, 32 insertions(+), 30 deletions(-) diff --git a/www/manager6/dc/CPUTypeView.js b/www/manager6/dc/CPUTypeView.js index d60c1330..11882b3c 100644 --- a/www/manager6/dc/CPUTypeView.js +++ b/www/manager6/dc/CPUTypeView.js @@ -103,36 +103,6 @@ Ext.define('PVE.dc.CPUTypeView', { }, ], - tbar: [ - { - text: gettext('Add'), - handler: 'onAdd', - }, - '-', - { - xtype: 'proxmoxStdRemoveButton', - baseurl: '/api2/extjs/cluster/qemu/custom-cpu-models/', - getRecordName: (rec) => rec.data.cputype, - getUrl: function (rec) { - let me = this; - return me.baseurl + rec.data.cputype; - }, - confirmMsg: function (rec) { - return Ext.String.format( - gettext("Are you sure you want to remove the custom CPU model '{0}'?"), - rec.data.cputype.replace(/^custom-/, ''), - ); - }, - callback: 'reload', - }, - { - xtype: 'proxmoxButton', - text: gettext('Edit'), - disabled: true, - handler: 'onEdit', - }, - ], - selModel: { xtype: 'rowmodel', }, @@ -146,6 +116,38 @@ Ext.define('PVE.dc.CPUTypeView', { initComponent: function () { let me = this; + let caps = Ext.state.Manager.get('GuiCap'); + let canEdit = !!caps.mapping['Mapping.Modify']; + + me.tbar = [ + { text: gettext('Add'), handler: 'onAdd', disabled: !canEdit }, + '-', + { + xtype: 'proxmoxStdRemoveButton', + baseurl: '/api2/extjs/cluster/qemu/custom-cpu-models/', + enableFn: (rec) => canEdit, + getRecordName: (rec) => rec.data.cputype, + getUrl: function (rec) { + let me = this; + return me.baseurl + rec.data.cputype; + }, + confirmMsg: function (rec) { + return Ext.String.format( + gettext("Are you sure you want to remove the custom CPU model '{0}'?"), + rec.data.cputype.replace(/^custom-/, ''), + ); + }, + callback: 'reload', + }, + { + xtype: 'proxmoxButton', + text: gettext('Edit'), + disabled: true, + enableFn: (_) => canEdit, + handler: 'onEdit', + }, + ]; + me.callParent(); Proxmox.Utils.monStoreErrors(me, me.store); }, -- 2.47.3