From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A95921FF141 for ; Tue, 19 May 2026 17:55:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4A01DD162; Tue, 19 May 2026 17:54:57 +0200 (CEST) From: Gabriel Goller To: pve-devel@lists.proxmox.com Subject: [PATCH manager] sdn: fabrics: fix wireguard node "Allowed IPs" setValue Date: Tue, 19 May 2026 17:44:32 +0200 Message-ID: <20260519154528.53144-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779205519529 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6B3HYHSK5GKV57WHRUWDNO5MCQWL6RUV X-Message-ID-Hash: 6B3HYHSK5GKV57WHRUWDNO5MCQWL6RUV X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Riley X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The setValue function on the "Allowed IPs" field on the wireguard fabric node did not get removed correctly. When removing the content, we use setRawValue, which only sets the displayed text and bypasses the form change checks. Copied the fix from form/BandwidthSelector.js, looks a bit ugly though because this is a named subclass, so callParent() doesn't work. Reported-by: David Riley Signed-off-by: Gabriel Goller --- www/manager6/sdn/fabrics/wireguard/NodeEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js b/www/manager6/sdn/fabrics/wireguard/NodeEdit.js index 9c9d2ce90bc3..ba5899cb9f1b 100644 --- a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js +++ b/www/manager6/sdn/fabrics/wireguard/NodeEdit.js @@ -79,7 +79,7 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', { value = value.join(', '); } - this.setRawValue(value); + return Ext.form.field.Text.prototype.setValue.call(this, value); }, getSubmitValue: function () { let value = this.getValue(); -- 2.47.3