From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 681011FF141 for ; Tue, 19 May 2026 16:38:42 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 13152A9C6; Tue, 19 May 2026 16:38:40 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH manager] ui: sdn: route map edit: use more consistent style for match/set grid Date: Tue, 19 May 2026 16:31:53 +0200 Message-ID: <20260519143804.3436951-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6WY3VIMPQLMOMEVKOVCT5YCSPLCE65JV X-Message-ID-Hash: 6WY3VIMPQLMOMEVKOVCT5YCSPLCE65JV X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: by using a widgetcolumn instead of an actioncolumn and putting the add button at the bottom of the grid. this is more in line what we usually do (with some exceptions). Also adapt the handlers to match the interface change from actioncolumn handler to button handler. Signed-off-by: Dominik Csapak --- www/manager6/sdn/RouteMapPanel.js | 46 ++++++++++++++++--------------- 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/www/manager6/sdn/RouteMapPanel.js b/www/manager6/sdn/RouteMapPanel.js index 46f243fb..f7776768 100644 --- a/www/manager6/sdn/RouteMapPanel.js +++ b/www/manager6/sdn/RouteMapPanel.js @@ -241,15 +241,14 @@ Ext.define('PVE.sdn.RouteMapSetField', { }, }, { - width: 20, - xtype: 'actioncolumn', - items: [ - { - tooltip: gettext('Delete'), - handler: 'deleteSet', - iconCls: 'fa critical fa-trash-o', - }, - ], + width: 40, + xtype: 'widgetcolumn', + widget: { + xtype: 'button', + tooltip: gettext('Delete'), + handler: 'deleteSet', + iconCls: 'fa fa-trash-o', + }, }, ], @@ -300,10 +299,11 @@ Ext.define('PVE.sdn.RouteMapSetField', { }; }, - tbar: [ + bbar: [ { xtype: 'button', text: gettext('Add'), + iconCls: 'fa fa-plus-circle', handler: 'addEntry', }, ], @@ -316,8 +316,9 @@ Ext.define('PVE.sdn.RouteMapSetField', { value: null, }); }, - deleteSet: function (_table, _rI, _cI, _item, _e, record) { + deleteSet: function (btn) { let me = this; + let record = btn.getWidgetRecord(); me.getView().getStore().remove(record); }, }, @@ -498,15 +499,14 @@ Ext.define('PVE.sdn.RouteMapMatchField', { }, }, { - width: 20, - xtype: 'actioncolumn', - items: [ - { - tooltip: gettext('Delete'), - handler: 'deleteMatch', - iconCls: 'fa critical fa-trash-o', - }, - ], + width: 40, + xtype: 'widgetcolumn', + widget: { + xtype: 'button', + tooltip: gettext('Delete'), + handler: 'deleteMatch', + iconCls: 'fa fa-trash-o', + }, }, ], @@ -558,10 +558,11 @@ Ext.define('PVE.sdn.RouteMapMatchField', { }; }, - tbar: [ + bbar: [ { xtype: 'button', text: gettext('Add'), + iconCls: 'fa fa-plus-circle', handler: 'addEntry', }, ], @@ -574,8 +575,9 @@ Ext.define('PVE.sdn.RouteMapMatchField', { value: null, }); }, - deleteMatch: function (_table, _rI, _cI, _item, _e, record) { + deleteMatch: function (btn) { let me = this; + let record = btn.getWidgetRecord(); me.getView().getStore().remove(record); }, }, -- 2.47.3