From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B6DC51FF141 for ; Tue, 19 May 2026 10:22:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 19234348E9; Tue, 19 May 2026 10:22:56 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH manager 1/2] ui: datacenter menu: remove 'guest resource' group Date: Tue, 19 May 2026 10:20:10 +0200 Message-ID: <20260519082222.560754-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: HJFH5ENV7F44L3KPLQL7TQQ6GIPYL3YE X-Message-ID-Hash: HJFH5ENV7F44L3KPLQL7TQQ6GIPYL3YE X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Since this is only an empty panel and the group is expanded by default, it does not gain us anything here. instead simply drop it and show it's children directly in the menu, saving us an empty panel and removing one entry from the default list. Signed-off-by: Dominik Csapak --- If we really want to have that group I'd propose some things: * collapse it by default, that way we'd at least save some space * patch the list such that clicking the group automatically selects the first entry below * add some actual content in there (e.g. rename it to just 'Hardware' and we could show an overview of the nodes an it's basic hardware such as cpu/mainboard/bios version from dmi info) www/manager6/dc/Config.js | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js index d303c8c0..5ad8522f 100644 --- a/www/manager6/dc/Config.js +++ b/www/manager6/dc/Config.js @@ -397,20 +397,6 @@ Ext.define('PVE.dc.Config', { ); } - if ( - caps.mapping['Mapping.Audit'] || - caps.mapping['Mapping.Use'] || - caps.mapping['Mapping.Modify'] - ) { - me.items.push({ - xtype: 'panel', - title: gettext('Guest Resources/Hardware'), - iconCls: 'fa fa-sitemap', - itemId: 'guestresourcesandhardware', - expandedOnInit: true, - }); - } - if ( caps.mapping['Mapping.Audit'] || caps.mapping['Mapping.Use'] || @@ -419,7 +405,6 @@ Ext.define('PVE.dc.Config', { me.items.push( { xtype: 'container', - groups: ['guestresourcesandhardware'], onlineHelp: 'resource_mapping', title: gettext('Resource Mappings'), itemId: 'resources', @@ -453,7 +438,6 @@ Ext.define('PVE.dc.Config', { }, { xtype: 'pveDcDirMapView', - groups: ['guestresourcesandhardware'], itemId: 'directories', title: gettext('Directory Mappings'), iconCls: 'fa fa-folder', @@ -468,7 +452,6 @@ Ext.define('PVE.dc.Config', { ) { me.items.push({ xtype: 'pveCPUTypeView', - groups: ['guestresourcesandhardware'], iconCls: 'fa fa-microchip', title: gettext('Custom CPU models'), itemId: 'cputypes', -- 2.47.3