all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-manager 2/3] ui: sdn: avoid flicker when opening wireguard dialogs
Date: Mon, 18 May 2026 17:07:46 +0200	[thread overview]
Message-ID: <20260518150747.103342-3-h.laimer@proxmox.com> (raw)
In-Reply-To: <20260518150747.103342-1-h.laimer@proxmox.com>

Without `hidden: true` fields appeard shortly before being hidden again
by the bind.

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
 www/manager6/sdn/fabrics/wireguard/InterfacePanel.js | 2 ++
 www/manager6/sdn/fabrics/wireguard/NodeEdit.js       | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/www/manager6/sdn/fabrics/wireguard/InterfacePanel.js b/www/manager6/sdn/fabrics/wireguard/InterfacePanel.js
index c3376011..65399451 100644
--- a/www/manager6/sdn/fabrics/wireguard/InterfacePanel.js
+++ b/www/manager6/sdn/fabrics/wireguard/InterfacePanel.js
@@ -291,6 +291,7 @@ Ext.define('PVE.sdn.Fabric.WireGuard.InterfacePanel', {
             border: false,
             flex: 1,
             width: 300,
+            hidden: true,
             layout: {
                 type: 'vbox',
                 pack: 'center',
@@ -317,6 +318,7 @@ Ext.define('PVE.sdn.Fabric.WireGuard.InterfacePanel', {
             flex: 1,
             width: 300,
             padding: 4,
+            hidden: true,
             items: [
                 {
                     xtype: 'proxmoxtextfield',
diff --git a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js b/www/manager6/sdn/fabrics/wireguard/NodeEdit.js
index 26c86bda..9c9d2ce9 100644
--- a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js
+++ b/www/manager6/sdn/fabrics/wireguard/NodeEdit.js
@@ -33,6 +33,7 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', {
             fieldLabel: gettext('Name'),
             labelWidth: 120,
             name: 'node_id',
+            hidden: true,
             bind: {
                 hidden: '{current.isPveNode}',
                 disabled: '{disableNameField}',
@@ -47,6 +48,7 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', {
             emptyText: gettext('base64-encoded WireGuard public key'),
             regex: /^[A-Za-z0-9+/]{43}=$/,
             regexText: gettext('WireGuard public key must be 44 base64 characters'),
+            hidden: true,
             bind: {
                 hidden: '{current.isPveNode}',
                 disabled: '{current.isPveNode}',
-- 
2.47.3





  parent reply	other threads:[~2026-05-18 15:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-18 15:07 [PATCH pve-manager 0/3] wireguard fabric node ui touch-ups Hannes Laimer
2026-05-18 15:07 ` [PATCH pve-manager 1/3] ui: sdn: improve wireguard node edit dialog with no interfaces Hannes Laimer
2026-05-18 15:07 ` Hannes Laimer [this message]
2026-05-18 15:07 ` [PATCH pve-manager 3/3] ui: sdn: skip delete confirmation for unsaved wireguard interfaces Hannes Laimer
2026-05-18 20:06 ` applied: [PATCH pve-manager 0/3] wireguard fabric node ui touch-ups Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260518150747.103342-3-h.laimer@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal