From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 230481FF14C for ; Fri, 15 May 2026 11:36:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9E3B8160E4; Fri, 15 May 2026 11:36:20 +0200 (CEST) From: Arthur Bied-Charreton To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager v5 20/21] ui: cpu flags selector: add search bar for large lists of flags Date: Fri, 15 May 2026 11:28:37 +0200 Message-ID: <20260515092839.238064-21-a.bied-charreton@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260515092839.238064-1-a.bied-charreton@proxmox.com> References: <20260515092839.238064-1-a.bied-charreton@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.182 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: COUBZH43PSCJGTON2E4BCYMRL7U736WM X-Message-ID-Hash: COUBZH43PSCJGTON2E4BCYMRL7U736WM X-MailFrom: abied-charreton@jett.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Add a search bar for the CPU flags list queried from /cluster/qemu/cpu-flags, which is very long. Do not display it for VM-specific flags (~15 flags), as they are easier to scan through, and it would overload the ProcessorEdit window. Signed-off-by: Arthur Bied-Charreton --- www/manager6/form/VMCPUFlagSelector.js | 48 ++++++++++++++++++++++++-- 1 file changed, 45 insertions(+), 3 deletions(-) diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js index f7a56b5a..574d44e0 100644 --- a/www/manager6/form/VMCPUFlagSelector.js +++ b/www/manager6/form/VMCPUFlagSelector.js @@ -62,7 +62,11 @@ Ext.define('PVE.form.VMCPUFlagSelector', { let flags = ''; - store.getData().each(function (rec) { + // Get the values directly from the data source. Using store.getData() here + // would iterate over the filtered values, potentially overwriting flags that + // are set but currently filtered out by the search bar. + let source = store.getDataSource(); + source.each(function (rec) { let s = rec.get('state'); if (s && s !== '=') { let f = rec.get('name'); @@ -277,7 +281,45 @@ Ext.define('PVE.form.VMCPUFlagSelector', { me.value = me.originalValue = ''; - me.dockedItems = [{ + me.dockedItems = []; + + if (!me.restrictToVMFlags) { + me.dockedItems.push({ + xtype: 'toolbar', + dock: 'top', + items: { + xtype: 'textfield', + emptyText: gettext('Search'), + submitValue: false, + listeners: { + change: { + buffer: 100, + fn: function (field, value) { + let store = field.up('grid').getStore(); + if (value) { + let lv = value.toLowerCase(); + store.addFilter({ + id: 'search-filter', + filterFn: (rec) => { + let name = rec.get('name') || ''; + let desc = rec.get('description') || ''; + return ( + name.toLowerCase().includes(lv) || + desc.toLowerCase().includes(lv) + ); + }, + }); + } else { + store.removeFilter('search-filter'); + } + }, + }, + }, + }, + }); + } + + me.dockedItems.push({ xtype: 'toolbar', dock: 'bottom', padding: '0 5', @@ -304,7 +346,7 @@ Ext.define('PVE.form.VMCPUFlagSelector', { }, }, ], - }]; + }); me.callParent(arguments); -- 2.47.3