From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 273211FF14C for ; Fri, 15 May 2026 10:55:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5FCF3118C0; Fri, 15 May 2026 10:54:25 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH manager v3 05/13] ui: revert button: add parentXType and reloadCallback Date: Fri, 15 May 2026 10:44:23 +0200 Message-ID: <20260515085349.1123127-6-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260515085349.1123127-1-d.csapak@proxmox.com> References: <20260515085349.1123127-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6HX4KSDCQ2O7KUGWHCAPJU5K6PAZ2O7E X-Message-ID-Hash: 6HX4KSDCQ2O7KUGWHCAPJU5K6PAZ2O7E X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: makes it useful in more situations when the direct parent is not a PendingObjectGrid but e.g. a pvePendingGrid. Signed-off-by: Dominik Csapak --- www/manager6/button/Revert.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/www/manager6/button/Revert.js b/www/manager6/button/Revert.js index 14b13f5b..d8fcca2c 100644 --- a/www/manager6/button/Revert.js +++ b/www/manager6/button/Revert.js @@ -7,11 +7,13 @@ Ext.define('PVE.button.PendingRevert', { config: { pendingGrid: null, apiurl: undefined, + parentXType: 'proxmoxPendingObjectGrid', + reloadCallback: undefined, }, handler: function () { if (!this.pendingGrid) { - this.pendingGrid = this.up('proxmoxPendingObjectGrid'); + this.pendingGrid = this.up(this.parentXType); if (!this.pendingGrid) { throw 'revert button requires a pendingGrid'; } @@ -23,7 +25,7 @@ Ext.define('PVE.button.PendingRevert', { return; } - let rowdef = view.rows[rec.data.key] || {}; + let rowdef = view.rows?.[rec.data.key] || {}; let keys = rowdef.multiKey || [rec.data.key]; Proxmox.Utils.API2Request({ @@ -34,7 +36,7 @@ Ext.define('PVE.button.PendingRevert', { params: { revert: keys.join(','), }, - callback: () => view.reload(), + callback: () => (this.reloadCallback ? this.reloadCallback() : view.reload()), failure: (response) => Ext.Msg.alert('Error', response.htmlStatus), }); }, -- 2.47.3