From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id C85AC1FF13A for ; Wed, 13 May 2026 15:07:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 60B8EE009; Wed, 13 May 2026 15:06:46 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH manager 5/8] fix #6819: storage: content view: fallback to approximate size Date: Wed, 13 May 2026 15:05:37 +0200 Message-ID: <20260513130548.143270-6-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260513130548.143270-1-f.ebner@proxmox.com> References: <20260513130548.143270-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778677548077 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2ZWKFRGJD434E7ZR54MQM422QIAXLE6P X-Message-ID-Hash: 2ZWKFRGJD434E7ZR54MQM422QIAXLE6P X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: For qcow2 volumes on LVM, if the LV is inactive, only an approximate size is returned instead of the exact size. Handle this case too. Signed-off-by: Fiona Ebner --- www/manager6/storage/ContentView.js | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/www/manager6/storage/ContentView.js b/www/manager6/storage/ContentView.js index 75b81e69..a4c2ef0d 100644 --- a/www/manager6/storage/ContentView.js +++ b/www/manager6/storage/ContentView.js @@ -187,7 +187,6 @@ Ext.define( size: { header: gettext('Size'), width: 100, - renderer: Proxmox.Utils.format_size, dataIndex: 'size', }, }; @@ -226,7 +225,20 @@ Ext.define( 'volid', 'content', 'format', - 'size', + { + name: 'size', + convert: function (value, record) { + if (value !== undefined) { + return Proxmox.Utils.format_size(value); + } else if (record.data['approximate-size'] !== undefined) { + return Ext.String.format( + '~{0}', + Proxmox.Utils.format_size(record.data['approximate-size']), + ); + } + return Proxmox.Utils.unknownText; + }, + }, 'used', 'vmid', 'channel', -- 2.47.3