all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Gabriel Goller <g.goller@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager] pvebanner: fix URL IPv6 address formatting
Date: Mon, 11 May 2026 11:35:52 +0200	[thread overview]
Message-ID: <20260511093554.102397-1-g.goller@proxmox.com> (raw)

Wrap IPv6 local IP address in brackets when generating the web UI
URL. Otherwise browsers (firefox and chromium tested) can't tell the
difference between port and ipv6 address segment.

Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
 bin/pvebanner | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/bin/pvebanner b/bin/pvebanner
index 7e8526101adf..6a214f74c04a 100755
--- a/bin/pvebanner
+++ b/bin/pvebanner
@@ -12,6 +12,8 @@ my $xline = '-' x 78;
 my $banner = '';
 
 if ($localip) {
+    my $urlip = $localip =~ m/:/ ? "[$localip]" : $localip;
+
     $banner .= <<__EOBANNER;
 
 $xline
@@ -19,7 +21,7 @@ $xline
 Welcome to the Proxmox Virtual Environment. Please use your web browser to 
 configure this server - connect to:
 
-  https://${localip}:8006/
+  https://${urlip}:8006/
 
 $xline
 
-- 
2.47.3





             reply	other threads:[~2026-05-11  9:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11  9:35 Gabriel Goller [this message]
2026-05-12  2:09 ` applied: [PATCH manager] pvebanner: fix URL IPv6 address formatting Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260511093554.102397-1-g.goller@proxmox.com \
    --to=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal