From: Shannon Sterz <s.sterz@proxmox.com>
To: yew-devel@lists.proxmox.com
Subject: [PATCH yew-comp/yew-mobile-gui v2 00/21] firewall tabs and clean up for pve-yew-mobile-gui
Date: Fri, 8 May 2026 17:57:01 +0200 [thread overview]
Message-ID: <20260508155722.464564-1-s.sterz@proxmox.com> (raw)
this series cleans up the pve-yew-mobile-gui a little bit. it does so by first
fixing a bug in proxmox-yew-comp. then pve-yew-mobile-gui is made clippy clean
again. the last six patches add, unify and clean up functionality in the gui.
the main changes are as follows:
* properly populate the rules tab of the existing firewall tabs and comment out
empty sub-tabs.
* add a firewall tab for container guests and nodes
* two small ui clean ups in how subscription levels and cpu utilization is
rendered
changes since v1:
* fix icon assign in the lxc and qemu status pages (added a new commit for the
qemu status page)
* remove commented out tab pages from the node firewall and align the order of
the tab pages for other firewall tabs with the desktop ui again.
yew-comp:
Shannon Sterz (1):
firewall rules panel: correct the url for the pve cluster firewall
rules
src/configuration/pve/firewall/firewall_rules_panel.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
yew-mobile-gui:
Shannon Sterz (20):
cargo.toml: globally ignore certain clippy lints
main: avoid unnecessary clones
tree-wide: collapse if statements
tree-wide: implement the `From` trait instead of the `Into` trait
tree-wide: implement `Default` for types with an `new()` constructor
tree-wide: remove unnecessary lazy evaluations
tree-wide: remove needless borrows
configuration page: remove redundant static lifetimes
resources/configuration page: remove useless `.into()` calls
tree-wide: fix several clippy lints
dashboard: use proper plural translation string instead of "CPU(s)"
configuration: clarify that "Firewall" shows the cluster's firewall
cluster/qemu firewall: use rules panel and comment out unused tabs
qemu status page: align icons better with tabs
lxc page: align layout for lxc guest with qemu guests
lxc: add support for a rudimentary firewall tab for lxc guests
node status: align layout for node status with guest pages
node: add a rudimentary firewall tab for cluster nodes
api types: remove unused file
resources page: map subscription level analogous to dashboard
Cargo.toml | 5 +
src/api_types.rs | 131 -------------
src/main.rs | 25 ++-
src/pages/mod.rs | 13 ++
src/pages/page_cluster_firewall/mod.rs | 63 ++++---
src/pages/page_configuartion.rs | 22 ++-
src/pages/page_dashboard.rs | 43 ++---
src/pages/page_login.rs | 12 +-
src/pages/page_lxc_status/dashboard_panel.rs | 70 ++++---
src/pages/page_lxc_status/firewall_panel.rs | 172 ++++++++++++++++++
src/pages/page_lxc_status/mod.rs | 47 ++++-
src/pages/page_lxc_tasks.rs | 6 +-
src/pages/page_node_status/dashboard_panel.rs | 6 +-
src/pages/page_node_status/firewall_panel.rs | 135 ++++++++++++++
src/pages/page_node_status/mod.rs | 37 +++-
src/pages/page_node_status/services_panel.rs | 2 +-
src/pages/page_node_tasks.rs | 6 +-
src/pages/page_qemu_status/dashboard_panel.rs | 77 ++++----
src/pages/page_qemu_status/firewall_panel.rs | 33 ++--
src/pages/page_qemu_status/mod.rs | 10 +-
src/pages/page_qemu_tasks.rs | 6 +-
src/pages/page_resources.rs | 50 ++---
src/pages/page_settings.rs | 12 +-
src/pages/page_storage_status.rs | 6 +-
src/pages/page_task_status.rs | 6 +-
src/widgets/guest_backup_panel.rs | 4 +-
src/widgets/task_list_button.rs | 29 +--
src/widgets/tasks_panel.rs | 2 +-
src/widgets/top_nav_bar.rs | 12 +-
29 files changed, 659 insertions(+), 383 deletions(-)
delete mode 100644 src/api_types.rs
create mode 100644 src/pages/page_lxc_status/firewall_panel.rs
create mode 100644 src/pages/page_node_status/firewall_panel.rs
Summary over all repositories:
30 files changed, 660 insertions(+), 384 deletions(-)
--
Generated by murpp 0.10.0
next reply other threads:[~2026-05-08 15:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 15:57 Shannon Sterz [this message]
2026-05-08 15:57 ` [PATCH yew-comp v2 01/21] firewall rules panel: correct the url for the pve cluster firewall rules Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 02/21] cargo.toml: globally ignore certain clippy lints Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 03/21] main: avoid unnecessary clones Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 04/21] tree-wide: collapse if statements Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 05/21] tree-wide: implement the `From` trait instead of the `Into` trait Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 06/21] tree-wide: implement `Default` for types with an `new()` constructor Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 07/21] tree-wide: remove unnecessary lazy evaluations Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 08/21] tree-wide: remove needless borrows Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 09/21] configuration page: remove redundant static lifetimes Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 10/21] resources/configuration page: remove useless `.into()` calls Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 11/21] tree-wide: fix several clippy lints Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 12/21] dashboard: use proper plural translation string instead of "CPU(s)" Shannon Sterz
2026-05-08 16:11 ` Shan Shaji
2026-05-08 16:13 ` Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 13/21] configuration: clarify that "Firewall" shows the cluster's firewall Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 14/21] cluster/qemu firewall: use rules panel and comment out unused tabs Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 15/21] qemu status page: align icons better with tabs Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 16/21] lxc page: align layout for lxc guest with qemu guests Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 17/21] lxc: add support for a rudimentary firewall tab for lxc guests Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 18/21] node status: align layout for node status with guest pages Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 19/21] node: add a rudimentary firewall tab for cluster nodes Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 20/21] api types: remove unused file Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 21/21] resources page: map subscription level analogous to dashboard Shannon Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260508155722.464564-1-s.sterz@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=yew-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.