From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: [PATCH widget-toolkit 1/2] add window and renderer for locations
Date: Fri, 8 May 2026 10:40:13 +0200 [thread overview]
Message-ID: <20260508084038.1405206-3-d.csapak@proxmox.com> (raw)
In-Reply-To: <20260508084038.1405206-1-d.csapak@proxmox.com>
PVE and PBS gained a location property (per node and datacenter) which
is a propertystring containing of a name and coordinates.
Add a window to edit and a renderer for that.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/Makefile | 1 +
src/Utils.js | 12 ++++++++
src/window/LocationEdit.js | 57 ++++++++++++++++++++++++++++++++++++++
3 files changed, 70 insertions(+)
create mode 100644 src/window/LocationEdit.js
diff --git a/src/Makefile b/src/Makefile
index 74ea4ab..9c52339 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -110,6 +110,7 @@ JSSRC= \
window/AddYubico.js \
window/TfaEdit.js \
window/NotesEdit.js \
+ window/LocationEdit.js \
window/ThemeEdit.js \
window/SyncWindow.js \
node/APT.js \
diff --git a/src/Utils.js b/src/Utils.js
index 5457ffa..390a302 100644
--- a/src/Utils.js
+++ b/src/Utils.js
@@ -1571,6 +1571,18 @@ Ext.define('Proxmox.Utils', {
}
hiddenElement.click();
},
+
+ renderLocation: function (value) {
+ if (!value) {
+ return Proxmox.Utils.NoneText;
+ }
+ let location = Proxmox.Utils.parsePropertyString(value);
+ let degrees = `${location.latitude} °, ${location.longitude} °`;
+ if (location.name) {
+ return `${location.name} (${degrees})`;
+ }
+ return degrees;
+ },
},
singleton: true,
diff --git a/src/window/LocationEdit.js b/src/window/LocationEdit.js
new file mode 100644
index 0000000..f7b6c6d
--- /dev/null
+++ b/src/window/LocationEdit.js
@@ -0,0 +1,57 @@
+Ext.define('Proxmox.window.LocationEdit', {
+ extend: 'Proxmox.window.Edit',
+ alias: 'widget.pmxLocationEditWindow',
+
+ title: gettext('Location'),
+
+ autoLoad: true,
+
+ items: [
+ {
+ xtype: 'inputpanel',
+ onGetValues: function (values) {
+ let propertyString = Proxmox.Utils.printPropertyString(values);
+ if (!propertyString) {
+ return { delete: 'location' };
+ } else {
+ return {
+ location: propertyString,
+ };
+ }
+ },
+
+ onSetValues: function (value) {
+ if (value.location) {
+ return Proxmox.Utils.parsePropertyString(value.location);
+ }
+ return {};
+ },
+
+ items: [
+ {
+ xtype: 'proxmoxtextfield',
+ fieldLabel: gettext('Name'),
+ allowBlank: true,
+ emptyText: gettext('Optional'),
+ name: 'name',
+ },
+ {
+ xtype: 'numberfield',
+ minimum: -90.0,
+ maximum: 90.0,
+ name: 'latitude',
+ decimalPrecision: 6,
+ fieldLabel: gettext('Latitude'),
+ },
+ {
+ xtype: 'numberfield',
+ minimum: -180.0,
+ maximum: 180.0,
+ name: 'longitude',
+ decimalPrecision: 6,
+ fieldLabel: gettext('Longitude'),
+ },
+ ],
+ },
+ ],
+});
--
2.47.3
next prev parent reply other threads:[~2026-05-08 8:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 8:40 [PATCH cluster/manager/proxmox{,-backup}/widget-toolkit 0/8] add location property to node/datacenter config for PVE/PBS Dominik Csapak
2026-05-08 8:40 ` [PATCH cluster 1/1] datacenter config: add location property Dominik Csapak
2026-05-08 8:40 ` Dominik Csapak [this message]
2026-05-08 8:40 ` [RFC PATCH widget-toolkit 2/2] utils: render location: add a link to that location on openstreetmap Dominik Csapak
2026-05-08 8:40 ` [PATCH manager 1/2] node config: add location property Dominik Csapak
2026-05-08 8:40 ` [PATCH manager 2/2] ui: add location to datacenter and node options Dominik Csapak
2026-05-08 8:40 ` [PATCH proxmox 1/1] pbs-api-types: node config: add location property Dominik Csapak
2026-05-08 8:40 ` [PATCH proxmox-backup 1/2] api: node: " Dominik Csapak
2026-05-08 8:40 ` [PATCH proxmox-backup 2/2] ui: node options: " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260508084038.1405206-3-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.