From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 6DDD01FF13F for ; Thu, 07 May 2026 08:55:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 53338B61C; Thu, 7 May 2026 08:55:51 +0200 (CEST) From: Arthur Bied-Charreton To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager] ui: qemu: wizard: re-add media=cdrom for second VirtIO drivers ISO Date: Thu, 7 May 2026 08:55:17 +0200 Message-ID: <20260507065517.237996-1-a.bied-charreton@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.109 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: MQKQ34JFRNEOQ54PZ3EP5RYABHAGDX76 X-Message-ID-Hash: MQKQ34JFRNEOQ54PZ3EP5RYABHAGDX76 X-MailFrom: abied-charreton@jett.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: d.riley@proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Commit f196d28f moved the ISO selector out of OSTypeInputPanel to a new OSPanel component, but left the onGetValues hook that appends the `media=cdrom` behind on OSTypeInputPanel, where ide0 now no longer appears. As a result, creating a Windows guest with the "Add additional drive for VirtIO drivers" checkbox enabled fails due to the missing explicit media=cdrom. Move the now-unreachable onGetValues logic from OSTypeInputPanel onto the wrapper inputpanel that now actually holds the ISO selector in OSPanel. Reported-by: David Riley Signed-off-by: Arthur Bied-Charreton --- www/manager6/qemu/OSPanel.js | 10 ++++++++++ www/manager6/qemu/OSTypeEdit.js | 11 ----------- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/www/manager6/qemu/OSPanel.js b/www/manager6/qemu/OSPanel.js index be0e5b85..556ad4c3 100644 --- a/www/manager6/qemu/OSPanel.js +++ b/www/manager6/qemu/OSPanel.js @@ -130,6 +130,16 @@ Ext.define('PVE.qemu.OSPanel', { }, { xtype: 'inputpanel', + onGetValues: function (values) { + if (values.ide0) { + let drive = { + media: 'cdrom', + file: values.ide0, + }; + values.ide0 = PVE.Parser.printQemuDrive(drive); + } + return values; + }, items: [ { xtype: 'proxmoxcheckbox', diff --git a/www/manager6/qemu/OSTypeEdit.js b/www/manager6/qemu/OSTypeEdit.js index 5c79164f..5a2f2ae6 100644 --- a/www/manager6/qemu/OSTypeEdit.js +++ b/www/manager6/qemu/OSTypeEdit.js @@ -36,17 +36,6 @@ Ext.define('PVE.qemu.OSTypeInputPanel', { } }, - onGetValues: function (values) { - if (values.ide0) { - let drive = { - media: 'cdrom', - file: values.ide0, - }; - values.ide0 = PVE.Parser.printQemuDrive(drive); - } - return values; - }, - initComponent: function () { var me = this; -- 2.47.3