From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 52CB71FF13B for ; Wed, 06 May 2026 14:49:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3F6C320AF7; Wed, 6 May 2026 14:49:13 +0200 (CEST) From: Shannon Sterz To: pve-devel@lists.proxmox.com Subject: [PATCH manager v2] cert helpers: make sure that any new certificate and key match Date: Wed, 6 May 2026 14:48:32 +0200 Message-ID: <20260506124832.246682-1-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778071608666 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.118 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [certhelpers.pm] Message-ID-Hash: LSVGJB6VTE4YKLIYOFSLZYLEOKYCUXSK X-Message-ID-Hash: LSVGJB6VTE4YKLIYOFSLZYLEOKYCUXSK X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: previously it was possible to upload and set a key and certificate combination, that did not match each other. this lead to confusing errors as pveproxy would seemingly start, but not actually serve any http connections. in a cluster context this leads to "broken pipe" errors when connecting to such a misconfigured node. since this is rather confusing, verify that a key and certificate can actually be used before setting them as the current certificates by loading them into a TLS context. Signed-off-by: Shannon Sterz --- Notes: this came up in the enterprise support and caused quite a bit of confusion. changes since v1 (thanks @ Thomas Lamprecht): - use `NET::SSLeay::die_now` instead of `die` to potentially return more useful debugging information. - add error handling when removing invalid keys/certificates fails. PVE/CertHelpers.pm | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/PVE/CertHelpers.pm b/PVE/CertHelpers.pm index ee945827f..202dec0ee 100644 --- a/PVE/CertHelpers.pm +++ b/PVE/CertHelpers.pm @@ -7,6 +7,8 @@ use PVE::Certificate; use PVE::JSONSchema; use PVE::Tools; +use Net::SSLeay qw(die_now); + my $account_prefix = '/etc/pve/priv/acme'; PVE::JSONSchema::register_standard_option( @@ -81,6 +83,31 @@ sub set_cert_files { PVE::Tools::file_set_contents($cert_path, $cert); PVE::Tools::file_set_contents($key_path, $key) if $key; $info = PVE::Certificate::get_certificate_info($cert_path); + + if (my $method = Net::SSLeay::TLS_method()) { + my $ctx = Net::SSLeay::CTX_new_with_method($method); + + eval { + Net::SSLeay::CTX_use_certificate_chain_file($ctx, $cert_path) + or die_now("could not load certificate (chain) ($!)"); + Net::SSLeay::CTX_use_PrivateKey_file( + $ctx, + $key_path, + Net::SSLeay::FILETYPE_PEM(), + ) or die_now("key does not match the certificate (chain) ($!)"); + }; + + my $err = $@; + + if ($err) { + # clean up invalid certificate and key + unlink $cert_path or $!{ENOENT} or warn "failed to clean-up $cert_path - $!\n"; + unlink $key_path or $!{ENOENT} or warn "failed to clean-up $key_path - $!\n"; + die $err; + } + } else { + warn "no TLS method to verify certificate and key match, continuing anyway\n"; + } }; my $err = $@; -- 2.47.3