From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 150C01FF13B for ; Wed, 06 May 2026 14:13:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 693DC1F323; Wed, 6 May 2026 14:13:39 +0200 (CEST) From: Erik Fastermann To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup v2 1/5] fix #6691: allow search by comment in datastore content Date: Wed, 6 May 2026 14:13:28 +0200 Message-ID: <20260506121332.21896-2-e.fastermann@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260506121332.21896-1-e.fastermann@proxmox.com> References: <20260506121332.21896-1-e.fastermann@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: B2EVWAAHJ2YQQA5VI4AULH3T3FLPACVF X-Message-ID-Hash: B2EVWAAHJ2YQQA5VI4AULH3T3FLPACVF X-MailFrom: root@erik-test-pbs.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Erik Fastermann X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Use case-insensitive matching, also for text and owner. Signed-off-by: Erik Fastermann --- changes since v1: * use case-insensitive matching for all fields, but with toLowerCase www/datastore/Content.js | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/www/datastore/Content.js b/www/datastore/Content.js index 1ec07505d..e963d62f9 100644 --- a/www/datastore/Content.js +++ b/www/datastore/Content.js @@ -933,15 +933,13 @@ Ext.define('PBS.DataStoreContent', { }, filter: function (item, value) { - if (item.data.text.indexOf(value) !== -1) { - return true; - } - - if (item.data.owner && item.data.owner.indexOf(value) !== -1) { - return true; - } + const needle = value.toLowerCase(); - return false; + return ( + item.data.text.toLowerCase().includes(needle) || + (item.data.owner && item.data.owner.toLowerCase().includes(needle)) || + (item.data.comment && item.data.comment.toLowerCase().includes(needle)) + ); }, search: function (tf, value) { @@ -1486,7 +1484,7 @@ Ext.define('PBS.DataStoreContent', { { xtype: 'textfield', reference: 'searchbox', - emptyText: gettext('group, date or owner'), + emptyText: gettext('group, date, owner or comment'), triggers: { clear: { cls: 'pmx-clear-trigger', -- 2.47.3