From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id DEA7A1FF13B for ; Wed, 06 May 2026 13:51:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BE9761E745; Wed, 6 May 2026 13:51:11 +0200 (CEST) From: Robert Obkircher To: pbs-devel@lists.proxmox.com Subject: [PATCH v1 proxmox-backup 3/3] client: pxar: skip files on fstatat permission errors Date: Wed, 6 May 2026 13:49:26 +0200 Message-ID: <20260506115016.171006-4-r.obkircher@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260506115016.171006-1-r.obkircher@proxmox.com> References: <20260506115016.171006-1-r.obkircher@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778068127104 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: MHHBNCWN2NMV2VLTCZRGOUIOAQ7NKDJC X-Message-ID-Hash: MHHBNCWN2NMV2VLTCZRGOUIOAQ7NKDJC X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Log a warning instead of aborting the entire backup if fstatat returns a permission error. This is preferable when running backups without full knowledge or control over the contents [1]. It is also more consistent with how we treat EACCES when opening files. Note that it was already possible to explicitly exclude such files[2]. [1] https://forum.proxmox.com/threads/bug-with-fuse-mounts.182315/ [2] https://bugzilla.proxmox.com/show_bug.cgi?id=4380 Signed-off-by: Robert Obkircher --- pbs-client/src/pxar/create.rs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pbs-client/src/pxar/create.rs b/pbs-client/src/pxar/create.rs index 47cbf50a8..c101415c1 100644 --- a/pbs-client/src/pxar/create.rs +++ b/pbs-client/src/pxar/create.rs @@ -710,6 +710,11 @@ impl Archiver { warn!("warning: file vanished while reading directory: {full_path:?}"); continue; } + Err(Errno::EACCES) => { + // may happen for fuse mountpoints without allow_other or allow_root + warn!("failed to stat file: {full_path:?}: access denied"); + continue; + } Err(Errno::ESTALE) => { self.report_stale_file_handle(Some(&full_path)); continue; -- 2.47.3