From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-manager 8/9] ui: sdn: fabric edit: allow defining multiple tabs
Date: Mon, 4 May 2026 18:31:53 +0200 [thread overview]
Message-ID: <20260504163157.429628-9-s.hanreich@proxmox.com> (raw)
In-Reply-To: <20260504163157.429628-1-s.hanreich@proxmox.com>
This allows for adding multiple tabs to the fabric edit window, which
can be used to include additional settings to the create/edit window
without cluttering the main view too much. The first use case is to
add support for route redistribution to the UI in subsequent commits.
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
www/manager6/sdn/fabrics/FabricEdit.js | 22 +++++++++++++++++++++-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/www/manager6/sdn/fabrics/FabricEdit.js b/www/manager6/sdn/fabrics/FabricEdit.js
index 6111bbb51..43a402a99 100644
--- a/www/manager6/sdn/fabrics/FabricEdit.js
+++ b/www/manager6/sdn/fabrics/FabricEdit.js
@@ -37,6 +37,7 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', {
],
additionalItems: [],
+ additionalTabs: [],
initComponent: function () {
let me = this;
@@ -97,7 +98,26 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', {
);
}
- me.items.push(...me.additionalItems);
+ if (me.additionalTabs.length > 0) {
+ let items = [...me.items, ...me.additionalItems];
+
+ let iPanel = Ext.create('Proxmox.panel.InputPanel', {
+ title: gettext('Fabric'),
+ items,
+ });
+
+ me.bodyPadding = 0;
+
+ me.items = [
+ {
+ xtype: 'tabpanel',
+ bodyPadding: 10,
+ items: [iPanel, ...me.additionalTabs],
+ },
+ ];
+ } else {
+ me.items.push(...me.additionalItems);
+ }
me.callParent();
},
--
2.47.3
next prev parent reply other threads:[~2026-05-04 16:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 16:31 [PATCH manager/network/proxmox-ve-rs 0/9] Implement route redistribution for OSPF Stefan Hanreich
2026-05-04 16:31 ` [PATCH proxmox-ve-rs 1/9] frr: ospf: add redistribute setting Stefan Hanreich
2026-05-04 16:31 ` [PATCH proxmox-ve-rs 2/9] frr-templates: render " Stefan Hanreich
2026-05-04 16:31 ` [PATCH proxmox-ve-rs 3/9] ve-config: add redistribute setting to ospf section config Stefan Hanreich
2026-05-04 16:31 ` [PATCH proxmox-ve-rs 4/9] ve-config: use constructor instead of instantiating struct Stefan Hanreich
2026-05-04 16:31 ` [PATCH proxmox-ve-rs 5/9] ve-config: ospf: generate redistribute config Stefan Hanreich
2026-05-04 16:31 ` [PATCH pve-network 6/9] fabrics: ospf: add redistribute to api types Stefan Hanreich
2026-05-04 16:31 ` [PATCH pve-manager 7/9] ui: sdn: fabrics: add redistribution grid component Stefan Hanreich
2026-05-04 16:31 ` Stefan Hanreich [this message]
2026-05-04 16:31 ` [PATCH pve-manager 9/9] ui: sdn: ospf fabric: add redistribution grid to ospf fabric Stefan Hanreich
2026-05-07 11:57 ` [PATCH manager/network/proxmox-ve-rs 0/9] Implement route redistribution for OSPF Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260504163157.429628-9-s.hanreich@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.